[GitHub] [superset] amitmiran137 commented on a change in pull request #13148: feat(native-filters): enable filter indicator and make datasource optional

[GitBox <gi...@apache.org>]

amitmiran137 commented on a change in pull request #13148:
URL: https://github.com/apache/superset/pull/13148#discussion_r576746365



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterValue.tsx
##########
@@ -51,15 +51,19 @@ const FilterValue: React.FC<FilterProps> = ({
   const { id, targets, filterType } = filter;
   const cascadingFilters = useCascadingFilters(id);
   const filterState = useFilterState(id);
-  const [loading, setLoading] = useState<boolean>(true);
   const [state, setState] = useState([]);
   const [error, setError] = useState<boolean>(false);
   const [formData, setFormData] = useState<Partial<QueryFormData>>({});
   const inputRef = useRef<HTMLInputElement>(null);
   const [target] = targets;
-  const { datasetId = 18, column } = target;
+  const {
+    datasetId = 18,

Review comment:
       why 18?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org