You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by VipinRathor <gi...@git.apache.org> on 2017/05/10 10:33:41 UTC

[GitHub] zeppelin pull request #2331: [minor] Replace 'SIMPLE' auth with 'simple' aut...

GitHub user VipinRathor opened a pull request:

    https://github.com/apache/zeppelin/pull/2331

    [minor] Replace 'SIMPLE' auth with 'simple' auth everywhere in documents

    ### What is this PR for?
    This PR fixes a security hole in documentation when 'SIMPLE' authentication mechanism is defined in Shiro configuration (http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/security/shiroauthentication.html). With that, user can log in without entering his/her password. Zeppelin documentation should recommend the correct value which is 'simple'.
    
    ### What type of PR is it?
    Documentation
    
    ### What is the Jira issue?
    N/A
    
    ### Questions:
    * Does the licenses files need update? no 
    * Is there breaking changes for older versions? no
    * Does this needs documentation? yes


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/VipinRathor/zeppelin fix-SIMPLE-auth-doc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2331
    
----
commit a1f0e48659df87248c1c31da46e4a7a9d7708ee0
Author: Vipin Rathor <v....@gmail.com>
Date:   2017-05-10T10:25:51Z

    [minor] Replace 'SIMPLE' auth with 'simple' auth everywhere in documents

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2331: [minor] Replace 'SIMPLE' auth with 'simple' auth every...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2331
  
    LGTM and merge to master and branch-0.7 if no further comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2331: [minor] Replace 'SIMPLE' auth with 'simple' auth every...

Posted by VipinRathor <gi...@git.apache.org>.

Github user VipinRathor commented on the issue:

    https://github.com/apache/zeppelin/pull/2331
  
    Thanks @felixcheung for spending time on this and approving.
    
    > but we should fix it to lower case always just to be safe?
    
    As per Shiro [doc](https://shiro.apache.org/static/1.2.4/apidocs/org/apache/shiro/realm/ldap/JndiLdapContextFactory.html) and JNDI LDAP [doc](https://docs.oracle.com/javase/tutorial/jndi/ldap/auth_mechs.html), the  acceptable values are 'none', 'simple', 'SASL' or 'DIGEST-MD5' etc. So converting AuthenticationMechanism value to lower case might not be a good idea.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2331: [minor] Replace 'SIMPLE' auth with 'simple' aut...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2331


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---