You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2017/10/13 13:39:53 UTC
Review Request 62974: Disallowed combining resource providers and
CheckpointResourcesMessage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62974/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jan Schlicht.
Bugs: MESOS-8058
https://issues.apache.org/jira/browse/MESOS-8058
Repository: mesos
Description
-------
Offer operations on resource provider resources can require
asynchronous handling since they can in principal take a long time to
complete. Additionally, they can fail even after passing validation in
the master, e.g., due to outside changes to the affected resources.
For these reasons, resource provider resources require an offer
operation protocol allowing failures outside of the master and
communicating these failures to the master.
Since this feedback can only be provided asynchronously, resource
provider resources are incompatible with `CheckpointResourcesMessage`
which by design updates the agent with the master's view of the
agent's resources, and does not account for asynchronous changes to
the agent's resources (leading e.g., to incompatible state between
master and agents).
This patch makes sure that agents with resource providers do not use
the 'CheckpointResourcesMessage' protocol. This prevents users from
running resource provider agents against legacy masters.
Diffs
-----
src/slave/slave.cpp 2e05637ed10a39eb3f4ce953506b1cb5d50caf3c
Diff: https://reviews.apache.org/r/62974/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 62974: Disallowed combining resource providers and
CheckpointResourcesMessage.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62974/#review187982
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62974]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 13, 2017, 1:39 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62974/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2017, 1:39 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-8058
> https://issues.apache.org/jira/browse/MESOS-8058
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Offer operations on resource provider resources can require
> asynchronous handling since they can in principal take a long time to
> complete. Additionally, they can fail even after passing validation in
> the master, e.g., due to outside changes to the affected resources.
> For these reasons, resource provider resources require an offer
> operation protocol allowing failures outside of the master and
> communicating these failures to the master.
>
> Since this feedback can only be provided asynchronously, resource
> provider resources are incompatible with `CheckpointResourcesMessage`
> which by design updates the agent with the master's view of the
> agent's resources, and does not account for asynchronous changes to
> the agent's resources (leading e.g., to incompatible state between
> master and agents).
>
> This patch makes sure that agents with resource providers do not use
> the 'CheckpointResourcesMessage' protocol. This prevents users from
> running resource provider agents against legacy masters.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 2e05637ed10a39eb3f4ce953506b1cb5d50caf3c
>
>
> Diff: https://reviews.apache.org/r/62974/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 62974: Disallowed combining resource providers and
CheckpointResourcesMessage.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62974/#review187997
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Oct. 13, 2017, 1:39 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62974/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2017, 1:39 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-8058
> https://issues.apache.org/jira/browse/MESOS-8058
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Offer operations on resource provider resources can require
> asynchronous handling since they can in principal take a long time to
> complete. Additionally, they can fail even after passing validation in
> the master, e.g., due to outside changes to the affected resources.
> For these reasons, resource provider resources require an offer
> operation protocol allowing failures outside of the master and
> communicating these failures to the master.
>
> Since this feedback can only be provided asynchronously, resource
> provider resources are incompatible with `CheckpointResourcesMessage`
> which by design updates the agent with the master's view of the
> agent's resources, and does not account for asynchronous changes to
> the agent's resources (leading e.g., to incompatible state between
> master and agents).
>
> This patch makes sure that agents with resource providers do not use
> the 'CheckpointResourcesMessage' protocol. This prevents users from
> running resource provider agents against legacy masters.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 2e05637ed10a39eb3f4ce953506b1cb5d50caf3c
>
>
> Diff: https://reviews.apache.org/r/62974/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 62974: Disallowed combining resource providers and
CheckpointResourcesMessage.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62974/#review187984
-----------------------------------------------------------
PASS: Mesos patch 62974 was successfully built and tested.
Reviews applied: `['62974']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62974
- Mesos Reviewbot Windows
On Oct. 13, 2017, 1:39 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62974/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2017, 1:39 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-8058
> https://issues.apache.org/jira/browse/MESOS-8058
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Offer operations on resource provider resources can require
> asynchronous handling since they can in principal take a long time to
> complete. Additionally, they can fail even after passing validation in
> the master, e.g., due to outside changes to the affected resources.
> For these reasons, resource provider resources require an offer
> operation protocol allowing failures outside of the master and
> communicating these failures to the master.
>
> Since this feedback can only be provided asynchronously, resource
> provider resources are incompatible with `CheckpointResourcesMessage`
> which by design updates the agent with the master's view of the
> agent's resources, and does not account for asynchronous changes to
> the agent's resources (leading e.g., to incompatible state between
> master and agents).
>
> This patch makes sure that agents with resource providers do not use
> the 'CheckpointResourcesMessage' protocol. This prevents users from
> running resource provider agents against legacy masters.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 2e05637ed10a39eb3f4ce953506b1cb5d50caf3c
>
>
> Diff: https://reviews.apache.org/r/62974/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>