You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/28 18:27:51 UTC
[GitHub] [arrow-rs] alamb opened a new issue #629: PROPOSAL: Mark the `alloc` and `buffer` and `bitmap` crates private
alamb opened a new issue #629:
URL: https://github.com/apache/arrow-rs/issues/629
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
As explained in https://github.com/apache/arrow-rs/pull/628 and linked mailing list comments, the `alloc` and `buffer` and `bitmap` crates are easy to misuse and can create undefined behavior.
Also, as part of the `arrow2` project @jorgecarleitao has effectively rewritten / removed them all anyways, so when we make the switch to an `arrow2` based future, any code that relies on these modules needs to be rewritten anyways.
**Describe the solution you'd like**
Mark the `alloc` and `buffer` and `bitmap` crates private so that users of the crate can not use them and can start preparing for the arrow2 transition
Proposed Transition plan:
1. Add a feature `unsafe` that publicly exposes these modules which is off by default. Users who need backwards compatibility can enable that feature.
2. Release said feature in 6.0.0
3. in 7.0.0 remove the feature flag, and ensure the
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ritchie46 commented on issue #629: PROPOSAL: Mark the `alloc` and `buffer` and `bitmap` crates private
Posted by GitBox <gi...@apache.org>.
ritchie46 commented on issue #629:
URL: https://github.com/apache/arrow-rs/issues/629#issuecomment-888879050
> Add a feature unsafe that publicly exposes these modules which is off by default. Users who need backwards compatibility can enable that feature.
As long as it stays possible to use it I am all for. Polars is dependent on those inner features and accepts the risk, as long as it is obviously properly tagged `unsafe`. :slightly_smiling_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] paddyhoran commented on issue #629: PROPOSAL: Mark the `alloc` and `buffer` and `bitmap` crates private
Posted by GitBox <gi...@apache.org>.
paddyhoran commented on issue #629:
URL: https://github.com/apache/arrow-rs/issues/629#issuecomment-888697885
Seems like a reasonable way to start to transition to the new arrow2 crate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org