You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AarryaSaraf (via GitHub)" <gi...@apache.org> on 2026/08/14 22:46:03 UTC
[PR] bench(parquet): cover large dictionary values in arrow_reader [arrow-rs]
AarryaSaraf opened a new pull request, #10691:
URL: https://github.com/apache/arrow-rs/pull/10691
# Which issue does this PR close?
None. This adds missing benchmark coverage; no library code changes.
# Rationale for this change
Every dictionary-encoded case in `arrow_reader` decodes ~20 byte values:
`build_dictionary_encoded_string_page_iterator` builds `"Dictionary value {x}"`
at 1% unique. At that size the decode is dominated by per-key overhead — RLE
index decoding and the per-key bounds check — and the cost of gathering the
dictionary values into the output buffer is negligible.
Binary columns holding large payloads are also commonly dictionary encoded, and
there the balance inverts: a page carries a handful of very large values behind
dictionary keys, and the gather dominates instead. No benchmark in the crate
covers that shape today, so changes to `OffsetBuffer::extend_from_dictionary`
have nothing to be measured against.
# What changes are included in this PR?
One generator and one case in the existing `BinaryArray` group:
- `build_dictionary_encoded_large_value_page_iterator` — 16 unique values of
64 KiB, 256 values per page, mandatory (no NULLs), otherwise the same
row-group and page geometry as the existing generators.
- `arrow_array_reader/BinaryArray/dictionary encoded, mandatory, no NULLs, large values`
128 MiB decoded per iteration. Measured on `main` (Apple M-series):
```
arrow_array_reader/BinaryArray/dictionary encoded, mandatory, no NULLs, large values
time: [9.8350 ms 9.9838 ms 10.118 ms]
```
# Are these changes tested?
This is a benchmark. It asserts its decoded value count on each run, as the
surrounding cases do.
# Are there any user-facing changes?
No.
# AI disclosure
This benchmark was drafted with AI assistance and reviewed by me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bench(parquet): cover large dictionary values in arrow_reader [arrow-rs]
Posted by "etseidl (via GitHub)" <gi...@apache.org>.
etseidl merged PR #10691:
URL: https://github.com/apache/arrow-rs/pull/10691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bench(parquet): cover large dictionary values in arrow_reader [arrow-rs]
Posted by "etseidl (via GitHub)" <gi...@apache.org>.
etseidl commented on PR #10691:
URL: https://github.com/apache/arrow-rs/pull/10691#issuecomment-5347351238
thanks @AarryaSaraf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bench(parquet): cover large dictionary values in arrow_reader [arrow-rs]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #10691:
URL: https://github.com/apache/arrow-rs/pull/10691#issuecomment-5347315063
🤖 Arrow criterion benchmark running (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/10691#issuecomment-5347285390)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c5347285390-1770-sx8rl 6.12.85+ #1 SMP Wed Jun 17 20:31:55 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing bench-dict-large-values (142cc80528c87294ba3e3d2abd0dc6e74dc04f3d) to b5794fb (merge-base) [diff](https://github.com/apache/arrow-rs/compare/b5794fbda02c45675e6ce83c916dae70c5df477a..142cc80528c87294ba3e3d2abd0dc6e74dc04f3d)
<details><summary>Run configuration</summary>
```yaml
run benchmark arrow_reader
env:
BENCH_FILTER: "large values"
```
</details>
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_reader
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bench(parquet): cover large dictionary values in arrow_reader [arrow-rs]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #10691:
URL: https://github.com/apache/arrow-rs/pull/10691#issuecomment-5347328403
🤖 Arrow criterion benchmark completed (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/10691#issuecomment-5347285390)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
Comparing bench-dict-large-values (142cc80528c87294ba3e3d2abd0dc6e74dc04f3d) to b5794fb (merge-base) [diff](https://github.com/apache/arrow-rs/compare/b5794fbda02c45675e6ce83c916dae70c5df477a..142cc80528c87294ba3e3d2abd0dc6e74dc04f3d)
<details><summary>Run configuration</summary>
```yaml
run benchmark arrow_reader
env:
BENCH_FILTER: "large values"
```
</details>
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
<details><summary>Details</summary>
<p>
```
group bench-dict-large-values
----- -----------------------
arrow_array_reader/BinaryArray/dictionary encoded, mandatory, no NULLs, large values 1.00 41.5±0.56ms ? ?/sec
```
</p>
</details>
<details><summary>Resource Usage</summary>
**base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 5.0s |
| Peak memory | 51.4 MiB |
| Avg memory | 9.2 MiB |
| CPU user | 0.6s |
| CPU sys | 0.0s |
| Peak spill | 0 B |
**branch**
| Metric | Value |
|--------|-------|
| Wall time | 15.0s |
| Peak memory | 190.3 MiB |
| Avg memory | 126.0 MiB |
| CPU user | 1.4s |
| CPU sys | 11.6s |
| Peak spill | 0 B |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bench(parquet): cover large dictionary values in arrow_reader [arrow-rs]
Posted by "etseidl (via GitHub)" <gi...@apache.org>.
etseidl commented on PR #10691:
URL: https://github.com/apache/arrow-rs/pull/10691#issuecomment-5347285390
run benchmark arrow_reader
```yaml
env:
BENCH_FILTER: large values
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org