You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "m-kuhn (via GitHub)" <gi...@apache.org> on 2025/02/09 17:45:12 UTC

[I] cmake config for all drivers [arrow-adbc]

m-kuhn opened a new issue, #2506:
URL: https://github.com/apache/arrow-adbc/issues/2506

### What feature or improvement would you like to see?

Only some of the drivers offer a cmake config, all of them offer pkgconfig.
It would be nice to offer cmake configs for all drivers.

Missing: bigquery, flightsql, snowflake

```
arrow-adbc provides CMake targets:

find_package(AdbcDriverManager CONFIG REQUIRED)
target_link_libraries(main PRIVATE AdbcDriverManager::adbc_driver_manager_static)

find_package(AdbcDriverPostgreSQL CONFIG REQUIRED)
target_link_libraries(main PRIVATE AdbcDriverPostgreSQL::adbc_driver_postgresql_static)

find_package(AdbcDriverSQLite CONFIG REQUIRED)
target_link_libraries(main PRIVATE AdbcDriverSQLite::adbc_driver_sqlite_static)

arrow-adbc provides pkg-config modules:

# The ADBC BigQuery driver provides an ADBC driver for BigQuery.
adbc-driver-bigquery

# The ADBC Flight SQL driver provides an ADBC driver for Flight SQL.
adbc-driver-flightsql

# ADBC driver manager provides API to use ADBC driver.
adbc-driver-manager

# The ADBC PostgreSQL driver provides an ADBC driver for PostgreSQL.
adbc-driver-postgresql

# The ADBC Snowflake driver provides an ADBC driver for Snowflake.
adbc-driver-snowflake

# The ADBC SQLite driver provides an ADBC driver for SQLite.
adbc-driver-sqlite
```

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] cmake config for all drivers [arrow-adbc]

Posted by "kou (via GitHub)" <gi...@apache.org>.

kou commented on issue #2506:
URL: https://github.com/apache/arrow-adbc/issues/2506#issuecomment-2662130045

   We can create `AdbcDriverFlightSQLConfig{,Version}.cmake` manually. It's not difficult. We just need to create a target in the `.cmake`. For example, `ArrowConfig.cmake` creates a target for `Arrow::arrow_bundled_dependencies`: https://github.com/apache/arrow/blob/27c639b99a8f13a1fd2c790c2850859aaaa198ac/cpp/src/arrow/ArrowConfig.cmake.in#L104
   
   (If you want, I can implement it. :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] cmake config for all drivers [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.

lidavidm commented on issue #2506:
URL: https://github.com/apache/arrow-adbc/issues/2506#issuecomment-2662110934

   Ugh, I think CMake is not quite set up to handle this. Essentially, we need to make an `install(EXPORT)` call, which needs `install(TARGETS)` calls, which we can't, because the fake targets we create don't have output artifacts associated with them (and from digging around, I don't see any way to do this). We're doing `install(FILES)` instead right now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] cmake config for all drivers [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.

lidavidm closed issue #2506: cmake config for all drivers
URL: https://github.com/apache/arrow-adbc/issues/2506


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] cmake config for all drivers [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.

lidavidm commented on issue #2506:
URL: https://github.com/apache/arrow-adbc/issues/2506#issuecomment-2662111207

   @kou do you know a way to fake this, or are we kind of stuck?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] cmake config for all drivers [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.

lidavidm commented on issue #2506:
URL: https://github.com/apache/arrow-adbc/issues/2506#issuecomment-2646887049

   Good catch, it appears all the Golang drivers are missing this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] cmake config for all drivers [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.

lidavidm closed issue #2506: cmake config for all drivers
URL: https://github.com/apache/arrow-adbc/issues/2506


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] cmake config for all drivers [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.

lidavidm commented on issue #2506:
URL: https://github.com/apache/arrow-adbc/issues/2506#issuecomment-2677292114

   Sorry for the late response. It would be much appreciated! m(__)m


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] cmake config for all drivers [arrow-adbc]

Posted by "kou (via GitHub)" <gi...@apache.org>.

kou commented on issue #2506:
URL: https://github.com/apache/arrow-adbc/issues/2506#issuecomment-2683986473

   Sure!
   #2561


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org