You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "gyfora (via GitHub)" <gi...@apache.org> on 2023/03/23 12:55:46 UTC
[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #550: [FLINK-31219] Add support for canary resources
gyfora opened a new pull request, #550:
URL: https://github.com/apache/flink-kubernetes-operator/pull/550
## What is the purpose of the change
While the current health probe mechanism is able to detect different types of errors like startup / informer issues it can be generally beneficial to allow a simply canary mechanism that can verify that the operator recieives updates and reconciles resources in a timely manner.
This PR introduces a simple canary mechanism that allows platform admins/users to deploy simple canary resources identified by a special label. The canary resource reconciliation logic then feeds into the Health probe through a configurable timeout which will be able to detect if the operator did not reconcile the resource.
The canary resource won't deploy any Flink resources.
## Brief change log
- *Add canary resource logic and canary resource manager to handle timeouts*
- *Wire canary logic into HealthProbe*
- *Add unit tests*
## Verifying this change
HealthProbe test has been extended with canary specific logic.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? [TODO]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #550: [FLINK-31219] Add support for canary resources
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on code in PR #550:
URL: https://github.com/apache/flink-kubernetes-operator/pull/550#discussion_r1146505879
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java:
##########
@@ -458,4 +458,12 @@ public static String operatorConfigKey(String key) {
.defaultValue(Duration.ofDays(1))
.withDescription(
"Time after which jobmanager pods of terminal application deployments are shut down.");
+
+ @Documentation.Section(SECTION_ADVANCED)
+ public static final ConfigOption<Duration> CANARY_RESOURCE_TIMEOUT =
+ operatorConfig("health.canary.resource.timeout")
Review Comment:
thanks, I need to regenerate the docs :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #550: [FLINK-31219] Add support for canary resources
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora merged PR #550:
URL: https://github.com/apache/flink-kubernetes-operator/pull/550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mateczagany commented on a diff in pull request #550: [FLINK-31219] Add support for canary resources
Posted by "mateczagany (via GitHub)" <gi...@apache.org>.
mateczagany commented on code in PR #550:
URL: https://github.com/apache/flink-kubernetes-operator/pull/550#discussion_r1146497775
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java:
##########
@@ -458,4 +458,12 @@ public static String operatorConfigKey(String key) {
.defaultValue(Duration.ofDays(1))
.withDescription(
"Time after which jobmanager pods of terminal application deployments are shut down.");
+
+ @Documentation.Section(SECTION_ADVANCED)
+ public static final ConfigOption<Duration> CANARY_RESOURCE_TIMEOUT =
+ operatorConfig("health.canary.resource.timeout")
Review Comment:
This does not match the config described in the documentation: `health.canary.deployment.timeout`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org