You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/02/23 03:39:08 UTC
[kudu-CR] [security] added info on non-renewable authn tokens
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6122
Change subject: [security] added info on non-renewable authn tokens
......................................................................
[security] added info on non-renewable authn tokens
It's not possible to renew Kudu authn tokens. That information is
added into the description of the --authn_token_validity_seconds
command-line flag.
I also opened KUDU-1895 JIRA case for adding corresponding information
into end-user documentation.
Change-Id: I44b5aedb05803ffba7a22f8127b2edac60d3752c
---
M src/kudu/master/master.cc
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/6122/1
--
To view, visit http://gerrit.cloudera.org:8080/6122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44b5aedb05803ffba7a22f8127b2edac60d3752c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [security] added info on non-renewable authn tokens
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [security] added info on non-renewable authn tokens
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6122/1/src/kudu/master/master.cc
File src/kudu/master/master.cc:
PS1, Line 64: re-new
> nit: "renew" one word
Done
PS1, Line 66: token
> "a token"
Done
PS1, Line 67: // TODO(PKI): docs for what actual effect this has, given we don't support
: // token renewal.
: T
> remove this TODO?
Yup, since the flag's command line doc has been updated and KUDU-1895 is filed, this is no longer need. Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/6122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b5aedb05803ffba7a22f8127b2edac60d3752c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [security] added info on non-renewable authn tokens
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [security] added info on non-renewable authn tokens
......................................................................
Patch Set 2: Verified+1
MasterFailoverTest.TestMasterPermanentFailure is a known flakey due to system-catalog-deadlock-on-shutdown.
--
To view, visit http://gerrit.cloudera.org:8080/6122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b5aedb05803ffba7a22f8127b2edac60d3752c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [security] added info on non-renewable authn tokens
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: [security] added info on non-renewable authn tokens
......................................................................
[security] added info on non-renewable authn tokens
It's not possible to renew Kudu authn tokens. That information is
added into the description of the --authn_token_validity_seconds
command-line flag.
I also opened KUDU-1895 JIRA case for adding corresponding information
into end-user documentation.
Change-Id: I44b5aedb05803ffba7a22f8127b2edac60d3752c
Reviewed-on: http://gerrit.cloudera.org:8080/6122
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/master/master.cc
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44b5aedb05803ffba7a22f8127b2edac60d3752c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [security] added info on non-renewable authn tokens
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [security] added info on non-renewable authn tokens
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6122/1/src/kudu/master/master.cc
File src/kudu/master/master.cc:
PS1, Line 64: re-new
nit: "renew" one word
PS1, Line 66: token
"a token"
PS1, Line 67: // TODO(PKI): docs for what actual effect this has, given we don't support
: // token renewal.
: T
remove this TODO?
--
To view, visit http://gerrit.cloudera.org:8080/6122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b5aedb05803ffba7a22f8127b2edac60d3752c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [security] added info on non-renewable authn tokens
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [security] added info on non-renewable authn tokens
......................................................................
Patch Set 1: Code-Review+1
LGTM modulo Todd's comments.
--
To view, visit http://gerrit.cloudera.org:8080/6122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b5aedb05803ffba7a22f8127b2edac60d3752c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [security] added info on non-renewable authn tokens
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [security] added info on non-renewable authn tokens
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b5aedb05803ffba7a22f8127b2edac60d3752c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [security] added info on non-renewable authn tokens
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6122
to look at the new patch set (#2).
Change subject: [security] added info on non-renewable authn tokens
......................................................................
[security] added info on non-renewable authn tokens
It's not possible to renew Kudu authn tokens. That information is
added into the description of the --authn_token_validity_seconds
command-line flag.
I also opened KUDU-1895 JIRA case for adding corresponding information
into end-user documentation.
Change-Id: I44b5aedb05803ffba7a22f8127b2edac60d3752c
---
M src/kudu/master/master.cc
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/6122/2
--
To view, visit http://gerrit.cloudera.org:8080/6122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44b5aedb05803ffba7a22f8127b2edac60d3752c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>