You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/08 23:16:33 UTC

[GitHub] [incubator-mxnet] Kh4L opened a new pull request #18675: ONNX import: use Conv pad attribute for symmetrical padding

Kh4L opened a new pull request #18675:
URL: https://github.com/apache/incubator-mxnet/pull/18675


   ## Description ##
   
   Importing an ONNX model was inserting Pad operators before Convolutions to support asymmetrical padding.
   This was useful for Convolutions with asymettrical padding but inefficient for symmetrical ones.
   
   ## Changes ##
   Check if the padding is symmetrical, if it is, add the `pad` attribute to the Convolution instead of creating a Pad operator.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] ptrendx merged pull request #18675: ONNX import: use Conv pad attribute for symmetrical padding

Posted by GitBox <gi...@apache.org>.
ptrendx merged pull request #18675:
URL: https://github.com/apache/incubator-mxnet/pull/18675


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18675: ONNX import: use Conv pad attribute for symmetrical padding

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18675:
URL: https://github.com/apache/incubator-mxnet/pull/18675#issuecomment-655805595


   Hey @Kh4L , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [clang, website, centos-cpu, windows-gpu, sanity, centos-gpu, unix-gpu, edge, windows-cpu, unix-cpu, miscellaneous]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org