You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/19 16:35:33 UTC
[GitHub] [arrow] lidavidm opened a new pull request, #15034: ARROW-18353: [C++][FlightRPC] Prevent concurrent Finish in UCX
lidavidm opened a new pull request, #15034:
URL: https://github.com/apache/arrow/pull/15034
The reader and writer can be used concurrently with each other,
and both may try to close the underlying stream when an error
happens. This can cause one side to stomp on the other's state
inadvertently. When that happens, we may or may not get a crash
or trigger an assertion - but sometimes things just happen to work
out, and the client exits without proper cleanup. The server,
however, doesn't realize this, and so it gets stuck waiting for
the client, preventing the test from finishing.
The longer-term fix would ideally be to let the server forcefully
terminate instead of waiting for clients. (Incidentally, this
problem also affects the gRPC transport, though gRPC is better
at detecting when the client has disappeared.) Here, we add more
assertions and also properly use a lock while doing cleanup.
Requires #15031.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #15034: ARROW-18353: [C++][FlightRPC] Prevent concurrent Finish in UCX
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #15034:
URL: https://github.com/apache/arrow/pull/15034#issuecomment-1366262847
Benchmark runs are scheduled for baseline = 9ac425941722c07b61331cea1ea0170a936de8be and contender = ceb2479d4486702f7faed5f26708822125939688. ceb2479d4486702f7faed5f26708822125939688 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2b399662938d4471bad877ea03238d62...6b2072774d12434c9fe4b12cb1cd9bd3/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/925c7fd7418240c3bb4319e5975b6c98...02fba19a2855470ab5ada48caf0f0a15/)
[Finished :arrow_down:1.02% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3cf3af15d73545b48d82545598207430...07e7ce3bdecb4a96b17c02cbe207a38e/)
[Finished :arrow_down:1.41% :arrow_up:0.31%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ad99f2757b0b43b1865fdbbc7e6c7ac7...407be584b15c4ab6b2b0edb624ba6c08/)
Buildkite builds:
[Finished] [`ceb2479d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2071)
[Failed] [`ceb2479d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2093)
[Finished] [`ceb2479d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2065)
[Finished] [`ceb2479d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2085)
[Finished] [`9ac42594` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2070)
[Failed] [`9ac42594` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2092)
[Finished] [`9ac42594` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2064)
[Finished] [`9ac42594` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2084)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #15034: ARROW-18353: [C++][FlightRPC] Prevent concurrent Finish in UCX
Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #15034:
URL: https://github.com/apache/arrow/pull/15034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #15034: ARROW-18353: [C++][FlightRPC] Prevent concurrent Finish in UCX
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #15034:
URL: https://github.com/apache/arrow/pull/15034#issuecomment-1366262936
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3cf3af15d73545b48d82545598207430...07e7ce3bdecb4a96b17c02cbe207a38e/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #15034: ARROW-18353: [C++][FlightRPC] Prevent concurrent Finish in UCX
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15034:
URL: https://github.com/apache/arrow/pull/15034#issuecomment-1357932859
https://issues.apache.org/jira/browse/ARROW-18353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org