[GitHub] [superset] lyndsiWilliams commented on a diff in pull request #20309: feat: Virtual dataset duplication

[GitBox <gi...@apache.org>]

lyndsiWilliams commented on code in PR #20309:
URL: https://github.com/apache/superset/pull/20309#discussion_r933703318


##########
superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx:
##########
@@ -118,6 +119,11 @@ type Dataset = {
   table_name: string;
 };
 
+interface VirtualDataset extends Dataset {
+  extra: any;

Review Comment:
   nit: Describe `extra` (I think it's `Record<string, any>` but I'm not 100% sure)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org