You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by la...@apache.org on 2013/10/09 21:10:01 UTC
svn commit: r1530769 - in
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver:
HRegionServer.java metrics/RegionServerMetrics.java
Author: larsh
Date: Wed Oct 9 19:10:01 2013
New Revision: 1530769
URL: http://svn.apache.org/r1530769
Log:
HBASE=9731 updatesBlockedSeconds RegionServer metric should not be a histogram
Modified:
hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
Modified: hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java?rev=1530769&r1=1530768&r2=1530769&view=diff
==============================================================================
--- hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java (original)
+++ hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Wed Oct 9 19:10:01 2013
@@ -1605,11 +1605,9 @@ public class HRegionServer implements HR
.getCompactionQueueSize());
this.metrics.flushQueueSize.set(cacheFlusher
.getFlushQueueSize());
- this.metrics.updatesBlockedSeconds.update(updatesBlockedMs > 0 ?
- updatesBlockedMs/1000: 0);
+ this.metrics.updatesBlockedSeconds.set(updatesBlockedMs/1000);
final long updatesBlockedMsHigherWater = cacheFlusher.getUpdatesBlockedMsHighWater().get();
- this.metrics.updatesBlockedSecondsHighWater.update(updatesBlockedMsHigherWater > 0 ?
- updatesBlockedMsHigherWater/1000: 0);
+ this.metrics.updatesBlockedSecondsHighWater.set(updatesBlockedMsHigherWater/1000);
BlockCache blockCache = cacheConfig.getBlockCache();
if (blockCache != null) {
Modified: hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java?rev=1530769&r1=1530768&r2=1530769&view=diff
==============================================================================
--- hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java (original)
+++ hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java Wed Oct 9 19:10:01 2013
@@ -300,13 +300,13 @@ public class RegionServerMetrics impleme
/**
* time blocked on lack of resources
*/
- public final MetricsHistogram updatesBlockedSeconds = new MetricsHistogram(
+ public final MetricsLongValue updatesBlockedSeconds = new MetricsLongValue(
"updatesBlockedSeconds", registry);
/**
* time blocked on memstoreHW
*/
- public final MetricsHistogram updatesBlockedSecondsHighWater = new MetricsHistogram(
+ public final MetricsLongValue updatesBlockedSecondsHighWater = new MetricsLongValue(
"updatesBlockedSecondsHighWater",registry);
public RegionServerMetrics() {