You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/12 11:33:58 UTC

[jira] [Commented] (CB-12227) Battery Status plugin cannot be built for windows using browserify

    [ https://issues.apache.org/jira/browse/CB-12227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15741683#comment-15741683 ] 

ASF GitHub Bot commented on CB-12227:
-------------------------------------

GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-plugin-battery-status/pull/46

    CB-12227 (windows) Fixed Browserify error

    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Fixes the `cordova run --browserify` error described here:
    https://issues.apache.org/jira/browse/CB-12227
    
    ### What testing has been done on this change?
    Successfully ran the browserified and unbrowserified apps on WIndows 10 Store.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-plugin-battery-status CB-12227

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-battery-status/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #46
    
----
commit bb5d4f92ef5b2a5576d0116d6dabe6f5bbd3951d
Author: Alexander Sorokin <al...@akvelon.com>
Date:   2016-12-12T11:29:54Z

    CB-12227 (windows) Fixed Browserify error

----


> Battery Status plugin cannot be built for windows using browserify
> ------------------------------------------------------------------
>
>                 Key: CB-12227
>                 URL: https://issues.apache.org/jira/browse/CB-12227
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Battery Status
>            Reporter: Alexander Sorokin
>            Assignee: Alexander Sorokin
>
> Repro:
> {noformat}
> cordova create foo
> cd foo
> cordova platform add windows
> cordova plugin add https://github.com/apache/cordova-plugin-battery-status
> cordova build --browserify
> {noformat}
> The error:
> {noformat}
> Error: 'return' outside of function (60:4) (while aliasify was processing C:\Cordova\foo\plugins\cordova-plugin-battery-status\src\windows\BatteryProxy.js) while parsing file: C:\Cordova\foo\plugins\cordova-plugin-battery-status\src\windows\BatteryProxy.js
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org