You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/03/14 23:55:26 UTC
Review Request 44813: GEODE-1097 allow Lambda invocations to be named
so that they show up in test logs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44813/
-----------------------------------------------------------
Review request for geode, Hitesh Khamesra, Jianxia Chen, Udo Kohlmeyer, and Dan Smith.
Repository: geode
Description
-------
This adds variants of VM.invoke() and VM.invokeAsync() that take a String name for the invocation that will be logged during dunit testing.
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java d4678cad1c19e2f9ef65e18c3a3dde4a0d4577a7
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NamedCallable.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NamedRunnable.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/VM.java 122aa0e34dfbd03212608843f7e39567441a18cf
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/BasicDUnitTest.java 068e81bb2508d0fec2fcfd60717443cc1deea0e3
Diff: https://reviews.apache.org/r/44813/diff/
Testing
-------
Thanks,
Bruce Schuchardt
Re: Review Request 44813: GEODE-1097 allow Lambda invocations to be
named so that they show up in test logs
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44813/#review123539
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On March 14, 2016, 10:55 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44813/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 10:55 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This adds variants of VM.invoke() and VM.invokeAsync() that take a String name for the invocation that will be logged during dunit testing.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java d4678cad1c19e2f9ef65e18c3a3dde4a0d4577a7
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NamedCallable.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NamedRunnable.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/VM.java 122aa0e34dfbd03212608843f7e39567441a18cf
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/BasicDUnitTest.java 068e81bb2508d0fec2fcfd60717443cc1deea0e3
>
> Diff: https://reviews.apache.org/r/44813/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 44813: GEODE-1097 allow Lambda invocations to be
named so that they show up in test logs
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44813/#review123531
-----------------------------------------------------------
Ship it!
Ship It!
- Udo Kohlmeyer
On March 14, 2016, 10:55 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44813/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 10:55 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This adds variants of VM.invoke() and VM.invokeAsync() that take a String name for the invocation that will be logged during dunit testing.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java d4678cad1c19e2f9ef65e18c3a3dde4a0d4577a7
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NamedCallable.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NamedRunnable.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/VM.java 122aa0e34dfbd03212608843f7e39567441a18cf
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/BasicDUnitTest.java 068e81bb2508d0fec2fcfd60717443cc1deea0e3
>
> Diff: https://reviews.apache.org/r/44813/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 44813: GEODE-1097 allow Lambda invocations to be
named so that they show up in test logs
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44813/#review123716
-----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/VM.java (line 262)
<https://reviews.apache.org/r/44813/#comment185960>
The first parameter should be nr, instead of r.
- Jianxia Chen
On March 14, 2016, 10:55 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44813/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 10:55 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This adds variants of VM.invoke() and VM.invokeAsync() that take a String name for the invocation that will be logged during dunit testing.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java d4678cad1c19e2f9ef65e18c3a3dde4a0d4577a7
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NamedCallable.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NamedRunnable.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/VM.java 122aa0e34dfbd03212608843f7e39567441a18cf
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/BasicDUnitTest.java 068e81bb2508d0fec2fcfd60717443cc1deea0e3
>
> Diff: https://reviews.apache.org/r/44813/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 44813: GEODE-1097 allow Lambda invocations to be
named so that they show up in test logs
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44813/#review123528
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On March 14, 2016, 10:55 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44813/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 10:55 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This adds variants of VM.invoke() and VM.invokeAsync() that take a String name for the invocation that will be logged during dunit testing.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java d4678cad1c19e2f9ef65e18c3a3dde4a0d4577a7
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NamedCallable.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NamedRunnable.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/VM.java 122aa0e34dfbd03212608843f7e39567441a18cf
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/BasicDUnitTest.java 068e81bb2508d0fec2fcfd60717443cc1deea0e3
>
> Diff: https://reviews.apache.org/r/44813/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 44813: GEODE-1097 allow Lambda invocations to be
named so that they show up in test logs
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44813/#review123721
-----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/BasicDUnitTest.java (line 103)
<https://reviews.apache.org/r/44813/#comment185967>
This is testing NamedCallable for invokeAsync. We also need a test that uses NamedRunnable. Same thing for vm.invoke.
- Jianxia Chen
On March 14, 2016, 10:55 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44813/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 10:55 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This adds variants of VM.invoke() and VM.invokeAsync() that take a String name for the invocation that will be logged during dunit testing.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java d4678cad1c19e2f9ef65e18c3a3dde4a0d4577a7
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NamedCallable.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/NamedRunnable.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/VM.java 122aa0e34dfbd03212608843f7e39567441a18cf
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/BasicDUnitTest.java 068e81bb2508d0fec2fcfd60717443cc1deea0e3
>
> Diff: https://reviews.apache.org/r/44813/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>