[GitHub] [arrow-datafusion] waynexia commented on pull request #5442: feat: `extensions_options` macro

["waynexia (via GitHub)" <gi...@apache.org>]

waynexia commented on PR #5442:
URL: https://github.com/apache/arrow-datafusion/pull/5442#issuecomment-1450473340

   >The issue with prog macros (which I think is what you mean with "attribute macros") is: they are slower, more complicated to write & test, and you ideally have a trait just for the prog macro because they are compiled just to check/document the downstream and you wanna avoid that for costly crates.
   
   Agree, I tried one recently and it does take me lots of time to debug :cry: 
   
   >If you meant "can you just use a macro syntax for defaults"? Ahh, maybe. If there's strong desire to do that, I can try (although I'm not sure if traditional macros can match on macro-like attributes).
   
   As long as the current implementation works fine and does not have ambiguous grammar, we can keep using it. And to me it's straitforward :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org