[jira] [Commented] (FLINK-13855) Keep Travis build in sync with module structure

["Chesnay Schepler (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-13855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959594#comment-16959594 ] 

Chesnay Schepler commented on FLINK-13855:
------------------------------------------

I would close this as won't fix. I agree that the messages can be a bit confusing, but it is easier from a maintenance perspective if every stage runs with the same profile. To me it is easier to reason about the build process if the settings are identical, and believe it is more likely for errors to slip in if the settings differ.

> Keep Travis build in sync with module structure
> -----------------------------------------------
>
>                 Key: FLINK-13855
>                 URL: https://issues.apache.org/jira/browse/FLINK-13855
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: 1.9.0, 1.10.0
>            Reporter: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.10.0
>
>
> We currently run all Travis profiles with {{-Pinclude-kinesis}} even though some of the build profiles don't contain the Kinesis connector module. Morever, we run every build profile with {{-Pskip-webui-build}} even though {{flink-runtime-web}} is not built by every profile. This causes Maven to log:
> {code}
> 19:15:47.404 [WARNING] The requested profile "skip-webui-build" could not be activated because it does not exist.
> 19:15:47.404 [WARNING] The requested profile "include-kinesis" could not be activated because it does not exist.
> {code}
> I think it would be good to keep the build on Travis in sync with the actual module structure and not specifying options for module where they are superfluous. This might prevent the accidental shadowing/inclusion of modules if the profiles change in the future.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)