[GitHub] HyukjinKwon commented on a change in pull request #23863: [SPARK-26960][ML] Wait for listener bus to clear in MLEventsSuite to reduce test flakiness

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #23863: [SPARK-26960][ML] Wait for listener bus to clear in MLEventsSuite to reduce test flakiness
URL: https://github.com/apache/spark/pull/23863#discussion_r259190027
 
 

 ##########
 File path: mllib/src/test/scala/org/apache/spark/ml/MLEventsSuite.scala
 ##########
 @@ -239,6 +239,7 @@ class MLEventsSuite
       events.map(JsonProtocol.sparkEventToJson).foreach { event =>
         assert(JsonProtocol.sparkEventFromJson(event).isInstanceOf[MLEvent])
       }
+      sc.listenerBus.waitUntilEmpty(timeoutMillis = 10000)
 
 Review comment:
   Maybe we can add an assert for the size of `MLEvent` of `events` within `eventually` to prevent too. But I think the current change is good enough. We can change it later if we see another actual issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org