You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "luigi malpeli (JIRA)" <ji...@codehaus.org> on 2007/11/27 10:16:57 UTC
[jira] Created: (MECLIPSE-358) plugin installed via
eclipse:install-plugins have the wrong name
plugin installed via eclipse:install-plugins have the wrong name
----------------------------------------------------------------
Key: MECLIPSE-358
URL: http://jira.codehaus.org/browse/MECLIPSE-358
Project: Maven 2.x Eclipse Plugin
Issue Type: Bug
Affects Versions: 2.4, 2.5
Environment: jdk 1.5.0_12 eclipse 3.2.x maven 2.0.7 win xp professional
Reporter: luigi malpeli
when processing eclipse:install-plugins the plugins are installed using just the artifactId as name. This gives problems at least in the following cases:
1) when trying to modify/construct from scratch an original eclipse installation;
2) when trying to install different plugins with the same artifactId and version but different groupId, the first installed atrifact or the latter wins depending on the overwrite=false/true parameter setting;
In my opinion the name should be a concat of the groupid a dot and the current proposed name.
I'll attach a proposed patch and some test files ASAP.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-358) plugin installed via
eclipse:install-plugins have the wrong name
Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_115482 ]
Carlos Sanchez commented on MECLIPSE-358:
-----------------------------------------
try changing the method like this then
private String formatEclipsePluginName( Artifact artifact, String bundleVersion )
{
return maven2OsgiConverter.getBundleSymbolicName( artifact ) + "_"
+ maven2OsgiConverter.getVersion( artifact.getVersion() );
}
> plugin installed via eclipse:install-plugins have the wrong name
> ----------------------------------------------------------------
>
> Key: MECLIPSE-358
> URL: http://jira.codehaus.org/browse/MECLIPSE-358
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: Dependencies resolution and build path
> Affects Versions: 2.4, 2.5
> Environment: jdk 1.5.0_12 eclipse 3.2.x maven 2.0.7 win xp professional
> Reporter: luigi malpeli
> Assignee: Carlos Sanchez
> Attachments: eclipse-create.zip, eclipse-plugin-patch.txt, eclipse.patch
>
>
> when processing eclipse:install-plugins the plugins are installed using just the artifactId as name. This gives problems at least in the following cases:
> 1) when trying to modify/construct from scratch an original eclipse installation;
> 2) when trying to install different plugins with the same artifactId and version but different groupId, the first installed atrifact or the latter wins depending on the overwrite=false/true parameter setting;
> In my opinion the name should be a concat of the groupid a dot and the current proposed name.
> I'll attach a proposed patch and some test files ASAP.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MECLIPSE-358) plugin installed via
eclipse:install-plugins have the wrong name
Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Sanchez closed MECLIPSE-358.
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.5
> plugin installed via eclipse:install-plugins have the wrong name
> ----------------------------------------------------------------
>
> Key: MECLIPSE-358
> URL: http://jira.codehaus.org/browse/MECLIPSE-358
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: Dependencies resolution and build path
> Affects Versions: 2.4, 2.5
> Environment: jdk 1.5.0_12 eclipse 3.2.x maven 2.0.7 win xp professional
> Reporter: luigi malpeli
> Assignee: Carlos Sanchez
> Fix For: 2.5
>
> Attachments: eclipse-create.zip, eclipse-plugin-patch.txt, eclipse.patch
>
>
> when processing eclipse:install-plugins the plugins are installed using just the artifactId as name. This gives problems at least in the following cases:
> 1) when trying to modify/construct from scratch an original eclipse installation;
> 2) when trying to install different plugins with the same artifactId and version but different groupId, the first installed atrifact or the latter wins depending on the overwrite=false/true parameter setting;
> In my opinion the name should be a concat of the groupid a dot and the current proposed name.
> I'll attach a proposed patch and some test files ASAP.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-358) plugin installed via
eclipse:install-plugins have the wrong name
Posted by "luigi malpeli (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_115244 ]
luigi malpeli commented on MECLIPSE-358:
----------------------------------------
sorry,
the ".jar" problem in in both in 2.4 and 2.5-SNAPSHOOT
> plugin installed via eclipse:install-plugins have the wrong name
> ----------------------------------------------------------------
>
> Key: MECLIPSE-358
> URL: http://jira.codehaus.org/browse/MECLIPSE-358
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Affects Versions: 2.4, 2.5
> Environment: jdk 1.5.0_12 eclipse 3.2.x maven 2.0.7 win xp professional
> Reporter: luigi malpeli
> Assignee: Carlos Sanchez
> Attachments: eclipse-create.zip, eclipse-plugin-patch.txt, eclipse.patch
>
>
> when processing eclipse:install-plugins the plugins are installed using just the artifactId as name. This gives problems at least in the following cases:
> 1) when trying to modify/construct from scratch an original eclipse installation;
> 2) when trying to install different plugins with the same artifactId and version but different groupId, the first installed atrifact or the latter wins depending on the overwrite=false/true parameter setting;
> In my opinion the name should be a concat of the groupid a dot and the current proposed name.
> I'll attach a proposed patch and some test files ASAP.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-358) plugin installed via
eclipse:install-plugins have the wrong name
Posted by "luigi malpeli (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_115659 ]
luigi malpeli commented on MECLIPSE-358:
----------------------------------------
Thanks Carlos, I did it already.
It works fine. I Didn't check all the eclipse plugins but about file names works properly now.
I think we can close the bug.
> plugin installed via eclipse:install-plugins have the wrong name
> ----------------------------------------------------------------
>
> Key: MECLIPSE-358
> URL: http://jira.codehaus.org/browse/MECLIPSE-358
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: Dependencies resolution and build path
> Affects Versions: 2.4, 2.5
> Environment: jdk 1.5.0_12 eclipse 3.2.x maven 2.0.7 win xp professional
> Reporter: luigi malpeli
> Assignee: Carlos Sanchez
> Attachments: eclipse-create.zip, eclipse-plugin-patch.txt, eclipse.patch
>
>
> when processing eclipse:install-plugins the plugins are installed using just the artifactId as name. This gives problems at least in the following cases:
> 1) when trying to modify/construct from scratch an original eclipse installation;
> 2) when trying to install different plugins with the same artifactId and version but different groupId, the first installed atrifact or the latter wins depending on the overwrite=false/true parameter setting;
> In my opinion the name should be a concat of the groupid a dot and the current proposed name.
> I'll attach a proposed patch and some test files ASAP.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-358) plugin installed via
eclipse:install-plugins have the wrong name
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arnaud Heritier updated MECLIPSE-358:
-------------------------------------
Component/s: Dependencies resolution and build path
> plugin installed via eclipse:install-plugins have the wrong name
> ----------------------------------------------------------------
>
> Key: MECLIPSE-358
> URL: http://jira.codehaus.org/browse/MECLIPSE-358
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: Dependencies resolution and build path
> Affects Versions: 2.4, 2.5
> Environment: jdk 1.5.0_12 eclipse 3.2.x maven 2.0.7 win xp professional
> Reporter: luigi malpeli
> Assignee: Carlos Sanchez
> Attachments: eclipse-create.zip, eclipse-plugin-patch.txt, eclipse.patch
>
>
> when processing eclipse:install-plugins the plugins are installed using just the artifactId as name. This gives problems at least in the following cases:
> 1) when trying to modify/construct from scratch an original eclipse installation;
> 2) when trying to install different plugins with the same artifactId and version but different groupId, the first installed atrifact or the latter wins depending on the overwrite=false/true parameter setting;
> In my opinion the name should be a concat of the groupid a dot and the current proposed name.
> I'll attach a proposed patch and some test files ASAP.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-358) plugin installed via
eclipse:install-plugins have the wrong name
Posted by "luigi malpeli (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
luigi malpeli updated MECLIPSE-358:
-----------------------------------
Attachment: eclipse-create.zip
eclipse-plugin-patch.txt
Attached is a proposed patch and a maven project that should create an eclipse installation (features will be simply added as resources in the attached test project) in /target/tmp
unfortunately I couldn't find eclipse plugins for the required version in maven central repository
as a starting point you shoud unzip the attached zip and use
mvn eclipse:to-maven -DeclipseDir=<path to your eclipse 3.2.1 folder>
from the "eclipse-create" folder
then run
mvn install -DeclipseDir=target/tmp/eclipse
Using the patch the generated eclipse installation will map the original one.
To define the pom I used an eclipse 3.2.1+ rcp delta pack, in case you use a different release, dependencies version or artifacts could be different, anyway to test the different behaviour just one dependency can be used.
> plugin installed via eclipse:install-plugins have the wrong name
> ----------------------------------------------------------------
>
> Key: MECLIPSE-358
> URL: http://jira.codehaus.org/browse/MECLIPSE-358
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Affects Versions: 2.4, 2.5
> Environment: jdk 1.5.0_12 eclipse 3.2.x maven 2.0.7 win xp professional
> Reporter: luigi malpeli
> Attachments: eclipse-create.zip, eclipse-plugin-patch.txt
>
>
> when processing eclipse:install-plugins the plugins are installed using just the artifactId as name. This gives problems at least in the following cases:
> 1) when trying to modify/construct from scratch an original eclipse installation;
> 2) when trying to install different plugins with the same artifactId and version but different groupId, the first installed atrifact or the latter wins depending on the overwrite=false/true parameter setting;
> In my opinion the name should be a concat of the groupid a dot and the current proposed name.
> I'll attach a proposed patch and some test files ASAP.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-358) plugin installed via
eclipse:install-plugins have the wrong name
Posted by "luigi malpeli (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_115241 ]
luigi malpeli commented on MECLIPSE-358:
----------------------------------------
Thanks Carlos,
the patch goes in the proper direction about the file name problem I reported before and is for sure complete to solve all the naming problem but has a new problem as it adds an extra ".jar" extension to file and to folders too in 2.4 plugin version.
ex.
org.eclipse.core.commands_3.2.0.I20060605_1400.jar.jar
that is a jar file and should be named org.eclipse.core.commands_3.2.0.I20060605_1400.jar
and
org.eclipse.pde.build_3.2.1.r321_v20060823.jar that is a folder and should be named org.eclipse.pde.build_3.2.1.r321_v20060823
without the jar extension
I'm not sure that this is the problem but DefaultMaven2OsgiConverter adds the extension.
public String getBundleFileName(Artifact artifact)
{
return getBundleSymbolicName(artifact) + "_" + getVersion(artifact.getVersion()) + ".jar";
}
> plugin installed via eclipse:install-plugins have the wrong name
> ----------------------------------------------------------------
>
> Key: MECLIPSE-358
> URL: http://jira.codehaus.org/browse/MECLIPSE-358
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Affects Versions: 2.4, 2.5
> Environment: jdk 1.5.0_12 eclipse 3.2.x maven 2.0.7 win xp professional
> Reporter: luigi malpeli
> Assignee: Carlos Sanchez
> Attachments: eclipse-create.zip, eclipse-plugin-patch.txt, eclipse.patch
>
>
> when processing eclipse:install-plugins the plugins are installed using just the artifactId as name. This gives problems at least in the following cases:
> 1) when trying to modify/construct from scratch an original eclipse installation;
> 2) when trying to install different plugins with the same artifactId and version but different groupId, the first installed atrifact or the latter wins depending on the overwrite=false/true parameter setting;
> In my opinion the name should be a concat of the groupid a dot and the current proposed name.
> I'll attach a proposed patch and some test files ASAP.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-358) plugin installed via
eclipse:install-plugins have the wrong name
Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Sanchez updated MECLIPSE-358:
------------------------------------
Attachment: eclipse.patch
luigi, can you try this patch instead?
> plugin installed via eclipse:install-plugins have the wrong name
> ----------------------------------------------------------------
>
> Key: MECLIPSE-358
> URL: http://jira.codehaus.org/browse/MECLIPSE-358
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Affects Versions: 2.4, 2.5
> Environment: jdk 1.5.0_12 eclipse 3.2.x maven 2.0.7 win xp professional
> Reporter: luigi malpeli
> Assignee: Carlos Sanchez
> Attachments: eclipse-create.zip, eclipse-plugin-patch.txt, eclipse.patch
>
>
> when processing eclipse:install-plugins the plugins are installed using just the artifactId as name. This gives problems at least in the following cases:
> 1) when trying to modify/construct from scratch an original eclipse installation;
> 2) when trying to install different plugins with the same artifactId and version but different groupId, the first installed atrifact or the latter wins depending on the overwrite=false/true parameter setting;
> In my opinion the name should be a concat of the groupid a dot and the current proposed name.
> I'll attach a proposed patch and some test files ASAP.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira