You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/13 16:17:22 UTC

[GitHub] [arrow-datafusion] andygrove commented on pull request #2211: fix: ‘Invalid identifier #xxx’ caused by Case-to-case conversion in SQL

andygrove commented on PR #2211:
URL: https://github.com/apache/arrow-datafusion/pull/2211#issuecomment-1098242516

   I haven't reviewed the entire codebase for how we handle case sensitivity of identifiers but it looks like DataFusion is case-sensitive today and this PR proposes to change it to case-insensitive.
   
   Postgres supports both case-sensitive and case-insensitive identifiers, depending on whether they are quoted or not, as described in https://www.postgresql.org/docs/current/sql-syntax-lexical.html
   
   Perhaps it would be better to follow Postgres's approach of converting unquoted identifiers to lower-case internally rather than change comparisons to use case-insensitive matching?
   
   @alamb What do you think?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org