[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20882: fix: invalid metric should raise an exception

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #20882:
URL: https://github.com/apache/superset/pull/20882#discussion_r930678558


##########
tests/integration_tests/viz_tests.py:
##########
@@ -716,7 +716,7 @@ def test_get_data_transforms_dataframe(self):
         self.assertEqual(data, expected)
 
     def test_get_data_empty_null_keys(self):
-        form_data = {"groupby": [], "metrics": ["", None]}

Review Comment:
   the metrics must be a `string` or `AdhocMetric`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org