You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "cmccabe (via GitHub)" <gi...@apache.org> on 2024/01/14 22:07:57 UTC
[PR] KAFKA-16126: Kcontroller dynamic configurations may fail to apply at startup [kafka]
cmccabe opened a new pull request, #15192:
URL: https://github.com/apache/kafka/pull/15192
Some kcontroller dynamic configurations may fail to apply at startup. This happens because there is a race between registering the reconfigurables to the DynamicBrokerConfig class, and receiving the first update from the metadata publisher. We can fix this by registering the reconfigurables first. This seems to have been introduced by the "MINOR: Install ControllerServer metadata publishers sooner" change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16126: Kcontroller dynamic configurations may fail to apply at startup [kafka]
Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe commented on PR #15192:
URL: https://github.com/apache/kafka/pull/15192#issuecomment-1891091446
I included a test. It sometimes passes even when the fix is not present, because of the nature of the bug. Adding a `Thread.sleep` makes it consistently fail in the buggy version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16126: Kcontroller dynamic configurations may fail to apply at startup [kafka]
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #15192:
URL: https://github.com/apache/kafka/pull/15192#issuecomment-1985996064
For completenss, the associated commit was merged to 3.6, 3.7 and trunk
3.6 -https://github.com/apache/kafka/commit/b743f6fd884132c7a5c4e9d96ed62e3aec29007f
3.7 - https://github.com/apache/kafka/commit/b40368330814888d7f7f2fda3f5b7ecfa1eabeb2
trunk - https://github.com/apache/kafka/commit/0015d0f01b130992acc37da85da6ee2088186a1f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16126: Kcontroller dynamic configurations may fail to apply at startup [kafka]
Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe closed pull request #15192: KAFKA-16126: Kcontroller dynamic configurations may fail to apply at startup
URL: https://github.com/apache/kafka/pull/15192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16126: Kcontroller dynamic configurations may fail to apply at startup [kafka]
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #15192:
URL: https://github.com/apache/kafka/pull/15192#issuecomment-1985979960
@cmccabe the test `testStartupWithNonDefaultKControllerDynamicConfiguration` has been failing since it has been introduced to 3.6 branch. See: https://ge.apache.org/scans/tests?search.relativeStartTime=P90D&search.rootProjectNames=kafka&search.tags=3.6&search.timeZoneId=Europe%2FBerlin&tests.container=kafka.server.KRaftClusterTest&tests.test=testStartupWithNonDefaultKControllerDynamicConfiguration()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16126: Kcontroller dynamic configurations may fail to apply at startup [kafka]
Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe commented on PR #15192:
URL: https://github.com/apache/kafka/pull/15192#issuecomment-1894711882
committed, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org