You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Venki Korukanti <ve...@gmail.com> on 2015/03/20 01:14:31 UTC
Review Request 32269: DRILL-2010: MergeJoin: Store/restore the right
batch state when existing join loop due to output batch full.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32269/
-----------------------------------------------------------
Review request for drill and Aman Sinha.
Repository: drill-git
Description
-------
Fixes incorrect result when using MergeJoin and both right/left side of the join are repeating in values.
This fix doesn't address the case where right value repeats across the batches.
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinStatus.java 299fd3a
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinTemplate.java 7da9788
Diff: https://reviews.apache.org/r/32269/diff/
Testing
-------
Tested with the repro case given in the bug. Test file is too big to attach for unittest. Will be asking QA to add it as part of functional test suite.
Thanks,
Venki Korukanti
Re: Review Request 32269: DRILL-2010: MergeJoin: Store/restore the
right batch state when existing join loop due to output batch full.
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32269/#review77149
-----------------------------------------------------------
Ship it!
MergeJoin code needs more cleanup/rework but this is a good step forward.
- Aman Sinha
On March 20, 2015, 12:14 a.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32269/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 12:14 a.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Fixes incorrect result when using MergeJoin and both right/left side of the join are repeating in values.
>
> This fix doesn't address the case where right value repeats across the batches.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinStatus.java 299fd3a
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinTemplate.java 7da9788
>
> Diff: https://reviews.apache.org/r/32269/diff/
>
>
> Testing
> -------
>
> Tested with the repro case given in the bug. Test file is too big to attach for unittest. Will be asking QA to add it as part of functional test suite.
>
>
> Thanks,
>
> Venki Korukanti
>
>