You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/08/15 06:28:20 UTC

[GitHub] [incubator-kyuubi] deadwind4 commented on a diff in pull request #3230: Flink SQL engine supports run across versions

deadwind4 commented on code in PR #3230:
URL: https://github.com/apache/incubator-kyuubi/pull/3230#discussion_r945453655


##########
.github/workflows/master.yml:
##########
@@ -111,12 +111,11 @@ jobs:
           - '1.15'
         flink-archive: [ "" ]
         comment: [ "normal" ]
-        # FIXME: Cross Flink versions verification is not supported yet
-        # include:
-          # - java: 8
-            # flink: '1.15'
-            # flink-archive: '-Dflink.archive.mirror=https://archive.apache.org/dist/flink/flink-1.14.5 -Dflink.archive.name=flink-1.14.5-bin-scala_2.12.tgz'
-            # comment: 'verify-flink-1.14'
+        include:
+          - java: 8
+            flink: '1.15'
+            flink-archive: '-Dflink.archive.mirror=https://archive.apache.org/dist/flink/flink-1.14.5 -Dflink.archive.name=flink-1.14.5-bin-scala_2.12.tgz'
+            comment: 'verify-flink-1.14'

Review Comment:
   ```suggestion
               comment: 'verify-engine-1.15-on-flink-1.14 '
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org