You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Konstantin Boudnik (JIRA)" <ji...@apache.org> on 2009/10/21 23:13:10 UTC
[jira] Created: (HADOOP-6326) Hundson runs should check for AspectJ
warnings and report failure if any is present
Hundson runs should check for AspectJ warnings and report failure if any is present
-----------------------------------------------------------------------------------
Key: HADOOP-6326
URL: https://issues.apache.org/jira/browse/HADOOP-6326
Project: Hadoop Common
Issue Type: Improvement
Components: build
Reporter: Konstantin Boudnik
Priority: Critical
When a code modifications break AspectJ bindings the following warning appears in the ant's build output:
{noformat}
[echo] Start weaving aspects in place
[iajc] warning at /Users/cos/work/branch-0.21/src/test/aop/org/apache/hadoop/hdfs/server/datanode/FSDatasetAspects.aj:55::0 advice defined in org.apache.hadoop.hdfs.server.datanode.FSDatasetAspects has not been applied [Xlint:adviceDidNotMatch]
[echo] Weaving of aspects is finished
{noformat}
Build process (in particular under Hudson) needs to check the output for such warnings and fail the build if any is present
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6326) Hundson runs should check for
AspectJ warnings and report failure if any is present
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769513#action_12769513 ]
Hudson commented on HADOOP-6326:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #70 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/70/])
. Hundson runs should check for AspectJ warnings and report failure if any is present. Contributed by Konstantin Boudnik
> Hundson runs should check for AspectJ warnings and report failure if any is present
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-6326
> URL: https://issues.apache.org/jira/browse/HADOOP-6326
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: HADOOP-6326.patch, HADOOP-6326.patch, HADOOP-6326.patch
>
>
> When a code modifications break AspectJ bindings the following warning appears in the ant's build output:
> {noformat}
> [echo] Start weaving aspects in place
> [iajc] warning at /Users/cos/work/branch-0.21/src/test/aop/org/apache/hadoop/hdfs/server/datanode/FSDatasetAspects.aj:55::0 advice defined in org.apache.hadoop.hdfs.server.datanode.FSDatasetAspects has not been applied [Xlint:adviceDidNotMatch]
> [echo] Weaving of aspects is finished
> {noformat}
> Build process (in particular under Hudson) needs to check the output for such warnings and fail the build if any is present
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6326) Hundson runs should check for
AspectJ warnings and report failure if any is present
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769305#action_12769305 ]
Konstantin Boudnik commented on HADOOP-6326:
--------------------------------------------
Yes, we could, perhaps. I wasn't able to find a solution for that (HDFS-584)
> Hundson runs should check for AspectJ warnings and report failure if any is present
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-6326
> URL: https://issues.apache.org/jira/browse/HADOOP-6326
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Konstantin Boudnik
> Priority: Critical
>
> When a code modifications break AspectJ bindings the following warning appears in the ant's build output:
> {noformat}
> [echo] Start weaving aspects in place
> [iajc] warning at /Users/cos/work/branch-0.21/src/test/aop/org/apache/hadoop/hdfs/server/datanode/FSDatasetAspects.aj:55::0 advice defined in org.apache.hadoop.hdfs.server.datanode.FSDatasetAspects has not been applied [Xlint:adviceDidNotMatch]
> [echo] Weaving of aspects is finished
> {noformat}
> Build process (in particular under Hudson) needs to check the output for such warnings and fail the build if any is present
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6326) Hundson runs should check for
AspectJ warnings and report failure if any is present
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769211#action_12769211 ]
Vinod K V commented on HADOOP-6326:
-----------------------------------
We can simply let the build fail, if that is possible with iajc. That way we don't need special checks at Hudson's test-patch.
> Hundson runs should check for AspectJ warnings and report failure if any is present
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-6326
> URL: https://issues.apache.org/jira/browse/HADOOP-6326
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Konstantin Boudnik
> Priority: Critical
>
> When a code modifications break AspectJ bindings the following warning appears in the ant's build output:
> {noformat}
> [echo] Start weaving aspects in place
> [iajc] warning at /Users/cos/work/branch-0.21/src/test/aop/org/apache/hadoop/hdfs/server/datanode/FSDatasetAspects.aj:55::0 advice defined in org.apache.hadoop.hdfs.server.datanode.FSDatasetAspects has not been applied [Xlint:adviceDidNotMatch]
> [echo] Weaving of aspects is finished
> {noformat}
> Build process (in particular under Hudson) needs to check the output for such warnings and fail the build if any is present
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6326) Hundson runs should check for
AspectJ warnings and report failure if any is present
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768465#action_12768465 ]
Konstantin Boudnik commented on HADOOP-6326:
--------------------------------------------
Most of AspectJ advises are located within HDFS code at the moment. We are seeing a significant number of such issues during an active code development (see HDFS-722 or HDFS-597).
> Hundson runs should check for AspectJ warnings and report failure if any is present
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-6326
> URL: https://issues.apache.org/jira/browse/HADOOP-6326
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Konstantin Boudnik
> Priority: Critical
>
> When a code modifications break AspectJ bindings the following warning appears in the ant's build output:
> {noformat}
> [echo] Start weaving aspects in place
> [iajc] warning at /Users/cos/work/branch-0.21/src/test/aop/org/apache/hadoop/hdfs/server/datanode/FSDatasetAspects.aj:55::0 advice defined in org.apache.hadoop.hdfs.server.datanode.FSDatasetAspects has not been applied [Xlint:adviceDidNotMatch]
> [echo] Weaving of aspects is finished
> {noformat}
> Build process (in particular under Hudson) needs to check the output for such warnings and fail the build if any is present
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-6326) Hundson runs should check for
AspectJ warnings and report failure if any is present
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik reassigned HADOOP-6326:
------------------------------------------
Assignee: Konstantin Boudnik
> Hundson runs should check for AspectJ warnings and report failure if any is present
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-6326
> URL: https://issues.apache.org/jira/browse/HADOOP-6326
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Priority: Critical
>
> When a code modifications break AspectJ bindings the following warning appears in the ant's build output:
> {noformat}
> [echo] Start weaving aspects in place
> [iajc] warning at /Users/cos/work/branch-0.21/src/test/aop/org/apache/hadoop/hdfs/server/datanode/FSDatasetAspects.aj:55::0 advice defined in org.apache.hadoop.hdfs.server.datanode.FSDatasetAspects has not been applied [Xlint:adviceDidNotMatch]
> [echo] Weaving of aspects is finished
> {noformat}
> Build process (in particular under Hudson) needs to check the output for such warnings and fail the build if any is present
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6326) Hundson runs should check for AspectJ
warnings and report failure if any is present
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-6326:
-------------------------------------------
Hadoop Flags: [Reviewed]
+1 patch looks good.
> Hundson runs should check for AspectJ warnings and report failure if any is present
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-6326
> URL: https://issues.apache.org/jira/browse/HADOOP-6326
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Priority: Critical
> Attachments: HADOOP-6326.patch, HADOOP-6326.patch, HADOOP-6326.patch
>
>
> When a code modifications break AspectJ bindings the following warning appears in the ant's build output:
> {noformat}
> [echo] Start weaving aspects in place
> [iajc] warning at /Users/cos/work/branch-0.21/src/test/aop/org/apache/hadoop/hdfs/server/datanode/FSDatasetAspects.aj:55::0 advice defined in org.apache.hadoop.hdfs.server.datanode.FSDatasetAspects has not been applied [Xlint:adviceDidNotMatch]
> [echo] Weaving of aspects is finished
> {noformat}
> Build process (in particular under Hudson) needs to check the output for such warnings and fail the build if any is present
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6326) Hundson runs should check for AspectJ
warnings and report failure if any is present
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6326:
---------------------------------------
Attachment: HADOOP-6326.patch
Copy-cat of HDFS-584. I've created new aspect with incorrectly specified pointcut and ran the build.
{noformat}
compile-fault-inject:
[echo] Start weaving aspects in place
[iajc] warning at /Users/xxx/work/Common/src/test/aop/org/apache/hadoop/fs/DUAspects.aj:11::0 advice defined in org.apache.hadoop.fs.DUAspects has not been applied [Xlint:adviceDidNotMatch]
BUILD FAILED
/Users/xxx/work/Common/src/test/aop/build/aop.xml:74: The following error occurred while executing this line:
/Users/xxx/work/Common/src/test/aop/build/aop.xml:57: /Users/xxx/work/Common/build-fi/compile-fi.log doesn't exist
Total time: 1 minute 16 seconds
{noformat}
> Hundson runs should check for AspectJ warnings and report failure if any is present
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-6326
> URL: https://issues.apache.org/jira/browse/HADOOP-6326
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Priority: Critical
> Attachments: HADOOP-6326.patch
>
>
> When a code modifications break AspectJ bindings the following warning appears in the ant's build output:
> {noformat}
> [echo] Start weaving aspects in place
> [iajc] warning at /Users/cos/work/branch-0.21/src/test/aop/org/apache/hadoop/hdfs/server/datanode/FSDatasetAspects.aj:55::0 advice defined in org.apache.hadoop.hdfs.server.datanode.FSDatasetAspects has not been applied [Xlint:adviceDidNotMatch]
> [echo] Weaving of aspects is finished
> {noformat}
> Build process (in particular under Hudson) needs to check the output for such warnings and fail the build if any is present
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6326) Hundson runs should check for
AspectJ warnings and report failure if any is present
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769636#action_12769636 ]
Hudson commented on HADOOP-6326:
--------------------------------
Integrated in Hadoop-Common-trunk #137 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/137/])
. Hundson runs should check for AspectJ warnings and report failure if any is present. Contributed by Konstantin Boudnik
> Hundson runs should check for AspectJ warnings and report failure if any is present
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-6326
> URL: https://issues.apache.org/jira/browse/HADOOP-6326
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Priority: Critical
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6326.patch, HADOOP-6326.patch, HADOOP-6326.patch
>
>
> When a code modifications break AspectJ bindings the following warning appears in the ant's build output:
> {noformat}
> [echo] Start weaving aspects in place
> [iajc] warning at /Users/cos/work/branch-0.21/src/test/aop/org/apache/hadoop/hdfs/server/datanode/FSDatasetAspects.aj:55::0 advice defined in org.apache.hadoop.hdfs.server.datanode.FSDatasetAspects has not been applied [Xlint:adviceDidNotMatch]
> [echo] Weaving of aspects is finished
> {noformat}
> Build process (in particular under Hudson) needs to check the output for such warnings and fail the build if any is present
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6326) Hundson runs should check for AspectJ
warnings and report failure if any is present
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6326:
---------------------------------------
Attachment: HADOOP-6326.patch
Fix for wrong property name
> Hundson runs should check for AspectJ warnings and report failure if any is present
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-6326
> URL: https://issues.apache.org/jira/browse/HADOOP-6326
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Priority: Critical
> Attachments: HADOOP-6326.patch, HADOOP-6326.patch
>
>
> When a code modifications break AspectJ bindings the following warning appears in the ant's build output:
> {noformat}
> [echo] Start weaving aspects in place
> [iajc] warning at /Users/cos/work/branch-0.21/src/test/aop/org/apache/hadoop/hdfs/server/datanode/FSDatasetAspects.aj:55::0 advice defined in org.apache.hadoop.hdfs.server.datanode.FSDatasetAspects has not been applied [Xlint:adviceDidNotMatch]
> [echo] Weaving of aspects is finished
> {noformat}
> Build process (in particular under Hudson) needs to check the output for such warnings and fail the build if any is present
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-6326) Hundson runs should check for
AspectJ warnings and report failure if any is present
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik resolved HADOOP-6326.
----------------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
It doesn't require full test-patch verification for the effect of the fix appears only when an aspect binding is broken.
Thanks for the review, Nicholas.
I've just committed this.
> Hundson runs should check for AspectJ warnings and report failure if any is present
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-6326
> URL: https://issues.apache.org/jira/browse/HADOOP-6326
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: HADOOP-6326.patch, HADOOP-6326.patch, HADOOP-6326.patch
>
>
> When a code modifications break AspectJ bindings the following warning appears in the ant's build output:
> {noformat}
> [echo] Start weaving aspects in place
> [iajc] warning at /Users/cos/work/branch-0.21/src/test/aop/org/apache/hadoop/hdfs/server/datanode/FSDatasetAspects.aj:55::0 advice defined in org.apache.hadoop.hdfs.server.datanode.FSDatasetAspects has not been applied [Xlint:adviceDidNotMatch]
> [echo] Weaving of aspects is finished
> {noformat}
> Build process (in particular under Hudson) needs to check the output for such warnings and fail the build if any is present
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6326) Hundson runs should check for AspectJ
warnings and report failure if any is present
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6326:
---------------------------------------
Attachment: HADOOP-6326.patch
Due to some specific of running <subant> parent directory of its log file has to exist ({{init}} target is called when <sunant> process is already started, while output is set before). Otherwise, the build will be failing on after {{clean}} runs
> Hundson runs should check for AspectJ warnings and report failure if any is present
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-6326
> URL: https://issues.apache.org/jira/browse/HADOOP-6326
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Priority: Critical
> Attachments: HADOOP-6326.patch, HADOOP-6326.patch, HADOOP-6326.patch
>
>
> When a code modifications break AspectJ bindings the following warning appears in the ant's build output:
> {noformat}
> [echo] Start weaving aspects in place
> [iajc] warning at /Users/cos/work/branch-0.21/src/test/aop/org/apache/hadoop/hdfs/server/datanode/FSDatasetAspects.aj:55::0 advice defined in org.apache.hadoop.hdfs.server.datanode.FSDatasetAspects has not been applied [Xlint:adviceDidNotMatch]
> [echo] Weaving of aspects is finished
> {noformat}
> Build process (in particular under Hudson) needs to check the output for such warnings and fail the build if any is present
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6326) Hundson runs should check for AspectJ
warnings and report failure if any is present
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6326:
---------------------------------------
Fix Version/s: 0.21.0
> Hundson runs should check for AspectJ warnings and report failure if any is present
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-6326
> URL: https://issues.apache.org/jira/browse/HADOOP-6326
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Priority: Critical
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6326.patch, HADOOP-6326.patch, HADOOP-6326.patch
>
>
> When a code modifications break AspectJ bindings the following warning appears in the ant's build output:
> {noformat}
> [echo] Start weaving aspects in place
> [iajc] warning at /Users/cos/work/branch-0.21/src/test/aop/org/apache/hadoop/hdfs/server/datanode/FSDatasetAspects.aj:55::0 advice defined in org.apache.hadoop.hdfs.server.datanode.FSDatasetAspects has not been applied [Xlint:adviceDidNotMatch]
> [echo] Weaving of aspects is finished
> {noformat}
> Build process (in particular under Hudson) needs to check the output for such warnings and fail the build if any is present
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.