You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/01/31 21:31:09 UTC

Review Request 30480: Use checkstyle 6.2.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30480/
-----------------------------------------------------------

Review request for Aurora and Maxim Khutornenko.


Bugs: AURORA-1081
    https://issues.apache.org/jira/browse/AURORA-1081


Repository: aurora


Description
-------

The configuration changes reflect features removed from checkstyle:

https://github.com/checkstyle/checkstyle/pull/209
https://github.com/checkstyle/checkstyle/issues/457


Diffs
-----

  build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 
  config/checkstyle/checkstyle.xml 20709896213b56c0dbdeaf790c826839383df20b 

Diff: https://reviews.apache.org/r/30480/diff/


Testing
-------


Thanks,

Bill Farner


Re: Review Request 30480: Use checkstyle 6.2.

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30480/#review70590
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On Jan. 31, 2015, 12:31 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30480/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2015, 12:31 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1081
>     https://issues.apache.org/jira/browse/AURORA-1081
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The configuration changes reflect features removed from checkstyle:
> 
> https://github.com/checkstyle/checkstyle/pull/209
> https://github.com/checkstyle/checkstyle/issues/457
> 
> 
> Diffs
> -----
> 
>   build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 
>   config/checkstyle/checkstyle.xml 20709896213b56c0dbdeaf790c826839383df20b 
> 
> Diff: https://reviews.apache.org/r/30480/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 30480: Use checkstyle 6.2.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30480/#review70584
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On Jan. 31, 2015, 8:31 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30480/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2015, 8:31 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1081
>     https://issues.apache.org/jira/browse/AURORA-1081
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The configuration changes reflect features removed from checkstyle:
> 
> https://github.com/checkstyle/checkstyle/pull/209
> https://github.com/checkstyle/checkstyle/issues/457
> 
> 
> Diffs
> -----
> 
>   build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 
>   config/checkstyle/checkstyle.xml 20709896213b56c0dbdeaf790c826839383df20b 
> 
> Diff: https://reviews.apache.org/r/30480/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 30480: Use checkstyle 6.2.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30480/#review70511
-----------------------------------------------------------

Ship it!


Master (a85db2e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 31, 2015, 8:31 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30480/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2015, 8:31 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1081
>     https://issues.apache.org/jira/browse/AURORA-1081
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The configuration changes reflect features removed from checkstyle:
> 
> https://github.com/checkstyle/checkstyle/pull/209
> https://github.com/checkstyle/checkstyle/issues/457
> 
> 
> Diffs
> -----
> 
>   build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 
>   config/checkstyle/checkstyle.xml 20709896213b56c0dbdeaf790c826839383df20b 
> 
> Diff: https://reviews.apache.org/r/30480/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>