[jira] Commented: (GERONIMO-2621) Exception handling in Console

["Don Hill (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GERONIMO-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492300 ] 

Don Hill commented on GERONIMO-2621:
------------------------------------

I think there are other ways to handle this so that as portlets are added to the console they don't have to develop to this pattern, why not create a abstract ConsolePortlet and let the abstract class handle the exception presentation.

catch the PortletException and call handleException(.) of the abstract class which could do a include for the error jsp. Another thought is that we could have an exception entry in web.xml that would catch the PortletException, this would then be handled by the container.

Just some thoughts ;)

> Exception handling in Console
> -----------------------------
>
>                 Key: GERONIMO-2621
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-2621
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: console
>    Affects Versions: 2.0-M5
>            Reporter: Rakesh Midha
>         Assigned To: Rakesh Midha
>             Fix For: 2.0-M5
>
>         Attachments: deployExp.patch
>
>
> This improvement is discussed in http://comments.gmane.org/gmane.comp.java.geronimo.devel/41449
> In case I get any exception or error condition in Console, the nothing is printed on web console and huge stack trace is printed on server console. Only thing done in the name of Exception handling in all the portlets is "throw PortletException"
> I somehow don't like this behavior of console. As a console user I don't want to go and see server stacktrace, if there is some error I should atleast be informed in console. I think everytime there is a error or exception in console, it should be printed in either exception page in webconsole, or in header of portlet view page. This is done to some extent in configManager and CA part of console. But not in uniform way.
> This is what I am proposing for Exception handling in console :
> 1. Create a ConsoleException.java which extends PortletException, this class will have overridden printStackTrace(PrintWriter), which will set attribute required in _ConsoleException.jsp apart from printing the stack on PrintWriter.
> 2. Create _ConsoleException.jsp which should be included in all portlet, this jsp will be responsible to print a short message and long stack trace. (with a toggle button to view and hide long stack trace)
> 3. All Portlet classes should throw ConsoleException instead of PortletException
> I think this will be nice and cleaner way to handle the console problems. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.