You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/04/17 23:03:46 UTC
[GitHub] [commons-lang] Isira-Seneviratne opened a new pull request #515:
Remove unnecessary unboxing in BooleanUtils.
Isira-Seneviratne opened a new pull request #515: Remove unnecessary unboxing in BooleanUtils.
URL: https://github.com/apache/commons-lang/pull/515
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] coveralls commented on issue #515: Remove
unnecessary unboxing in BooleanUtils.
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #515: Remove unnecessary unboxing in BooleanUtils.
URL: https://github.com/apache/commons-lang/pull/515#issuecomment-615502741
[](https://coveralls.io/builds/30160012)
Coverage remained the same at 95.094% when pulling **fbbca664c0ab1a477795794ae6515ca6e71b0a8a on Isira-Seneviratne:Remove_unboxing_in_BooleanUtils** into **e9225d05b25122e0914f1c6f200aaf8fe0e6a75c on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] kinow commented on issue #515: Remove unnecessary
unboxing in BooleanUtils.
Posted by GitBox <gi...@apache.org>.
kinow commented on issue #515: Remove unnecessary unboxing in BooleanUtils.
URL: https://github.com/apache/commons-lang/pull/515#issuecomment-615514870
> IntelliJ flagged the unboxing operations as unnecessary.
That's OK. There are other warnings in IntelliJ, Eclipse, SonarCloud, and other tools that perform static analysis that are not always addressed in Commons (and in other projects too, run a static analyser through Python Pandas and you will find a lot of warnings).
Commons has several low level libraries, like Lang. Where there is an explicit difference between objects/primitives since a long time ago. The final byte code might look the same, but the code base is probably distinguishing both. So no need to change that :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] garydgregory commented on issue #515: Remove
unnecessary unboxing in BooleanUtils.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on issue #515: Remove unnecessary unboxing in BooleanUtils.
URL: https://github.com/apache/commons-lang/pull/515#issuecomment-615502371
-1 from my POV. In a low-level library like Commons Lang we should make explicit where we mix primitives and Objects. I want to be made aware of where the boxing and unboxing do in fact take place, which will have consequences depending on some use cases. Boxing is not just syntactical sugar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] kinow commented on issue #515: Remove unnecessary
unboxing in BooleanUtils.
Posted by GitBox <gi...@apache.org>.
kinow commented on issue #515: Remove unnecessary unboxing in BooleanUtils.
URL: https://github.com/apache/commons-lang/pull/515#issuecomment-615512356
> -1 from my POV. In a low-level library like Commons Lang we should make explicit where we mix primitives and Objects. I want to be made aware of where the boxing and unboxing do in fact take place, which will have consequences depending on some use cases. Boxing is not just syntactical sugar.
I thought that would be OK given we were checking for `null` in all the cases, but agree on the part about being a low level library and being explicit on primitive vs. Object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] Isira-Seneviratne commented on issue #515: Remove
unnecessary unboxing in BooleanUtils.
Posted by GitBox <gi...@apache.org>.
Isira-Seneviratne commented on issue #515: Remove unnecessary unboxing in BooleanUtils.
URL: https://github.com/apache/commons-lang/pull/515#issuecomment-615513921
IntelliJ flagged the unboxing operations as unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services