You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2021/06/02 13:08:15 UTC
[GitHub] [knox] smolnar82 opened a new pull request #452: KNOX-2616 - Removed trailing slashes service context generation
smolnar82 opened a new pull request #452:
URL: https://github.com/apache/knox/pull/452
## What changes were proposed in this pull request?
Extra trailing slash in the generated service context caused problems.
## How was this patch tested?
Updated JUnit tests and tested many of the supported service UIs in my own cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 merged pull request #452: KNOX-2616 - Removed trailing slashes service context generation
Posted by GitBox <gi...@apache.org>.
smolnar82 merged pull request #452:
URL: https://github.com/apache/knox/pull/452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 removed a comment on pull request #452: KNOX-2616 - Removed trailing slashes service context generation
Posted by GitBox <gi...@apache.org>.
smolnar82 removed a comment on pull request #452:
URL: https://github.com/apache/knox/pull/452#issuecomment-853625828
Thanks, @stoty for your comment. I did a smoke test in a local cluster with all the service UIs available and found the following services need the trailing slash: Oozie, Ranger, Solr, Zeppelin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] stoty commented on pull request #452: KNOX-2616 - Removed trailing slashes service context generation
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #452:
URL: https://github.com/apache/knox/pull/452#issuecomment-853019011
When I tested, the UI pages for some services, look the Oozie UI, didn't load without the trailing slash.
As it is kind of hopeless to test every single service, the most straightforward thing to do is to re-add the slash in the service.xml files (except where the <context> tag contains URL parameters)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #452: KNOX-2616 - Removed trailing slashes service context generation
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #452:
URL: https://github.com/apache/knox/pull/452#issuecomment-853625828
Thanks, @stoty for your comment. I did a smoke test in a local cluster with all the service UIs available and found the following services need the trailing slash: Oozie, Ranger, Solr, Zeppelin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] stoty edited a comment on pull request #452: KNOX-2616 - Removed trailing slashes service context generation
Posted by GitBox <gi...@apache.org>.
stoty edited a comment on pull request #452:
URL: https://github.com/apache/knox/pull/452#issuecomment-853019011
When I tested, the UI pages for some services, like the Oozie UI, didn't load without the trailing slash.
As it is kind of hopeless to test every single service, the most straightforward thing to do is to re-add the trailing slash in the service.xml files (except where the context tag contains URL parameters)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] stoty edited a comment on pull request #452: KNOX-2616 - Removed trailing slashes service context generation
Posted by GitBox <gi...@apache.org>.
stoty edited a comment on pull request #452:
URL: https://github.com/apache/knox/pull/452#issuecomment-853019011
When I tested, the UI pages for some services, like the Oozie UI, didn't load without the trailing slash.
As it is kind of hopeless to test every single service, the most straightforward thing to do is to re-add the trailing slash in the service.xml files (except where the <context> tag contains URL parameters)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #452: KNOX-2616 - Removed trailing slashes service context generation
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #452:
URL: https://github.com/apache/knox/pull/452#issuecomment-853625828
Thanks, @stoty for your comment. I did a smoke test in a local cluster with all the service UIs available and found the following services need the trailing slash: Oozie, Ranger, Solr, Zeppelin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 merged pull request #452: KNOX-2616 - Removed trailing slashes service context generation
Posted by GitBox <gi...@apache.org>.
smolnar82 merged pull request #452:
URL: https://github.com/apache/knox/pull/452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 removed a comment on pull request #452: KNOX-2616 - Removed trailing slashes service context generation
Posted by GitBox <gi...@apache.org>.
smolnar82 removed a comment on pull request #452:
URL: https://github.com/apache/knox/pull/452#issuecomment-853625828
Thanks, @stoty for your comment. I did a smoke test in a local cluster with all the service UIs available and found the following services need the trailing slash: Oozie, Ranger, Solr, Zeppelin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org