You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/10 09:47:57 UTC
[GitHub] [pulsar] BewareMyPower opened a new pull request #13233: [Client] Fix memory leak when message payload processor is configured
BewareMyPower opened a new pull request #13233:
URL: https://github.com/apache/pulsar/pull/13233
### Motivation
When `MessagePayloadProcessor` is configured, there will be a memory leak caused by unused `MessagePayloadContextImpl#recyclerHandle`.
### Modifications
Call `recycle()` to recycle the `MessagePayloadContextImpl` object in `recycle()` method.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #13233: [Client] Fix memory leak when message payload processor is configured
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #13233:
URL: https://github.com/apache/pulsar/pull/13233#issuecomment-991710265
> BTW, I have sent an email to discuss about if there is any way to detect unused variables. If we can detect the unused private fields in CI, this bug could be exposed in time.
@BewareMyPower Good point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #13233: [Client] Fix memory leak when message payload processor is configured
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #13233:
URL: https://github.com/apache/pulsar/pull/13233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #13233: [Client] Fix memory leak when message payload processor is configured
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #13233:
URL: https://github.com/apache/pulsar/pull/13233#issuecomment-991710265
> BTW, I have sent an email to discuss about if there is any way to detect unused variables. If we can detect the unused private fields in CI, this bug could be exposed in time.
@BewareMyPower Good point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #13233: [Client] Fix memory leak when message payload processor is configured
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #13233:
URL: https://github.com/apache/pulsar/pull/13233#issuecomment-990809417
@codelipenghui I think the behavior depends on the implementation of Netty recycler.
BTW, I have sent [an email](https://lists.apache.org/thread/9jmytp51f2o4gp9w2vsf1fyxg3dkjlfd) to discuss about if there is any way to detect unused variables. If we can detect the unused private fields in CI, this bug could be exposed in time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #13233: [Client] Fix memory leak when message payload processor is configured
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13233:
URL: https://github.com/apache/pulsar/pull/13233#issuecomment-990795686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org