You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "menghaoranss (via GitHub)" <gi...@apache.org> on 2026/08/10 10:06:14 UTC
[PR] Add logical default schema lookup to ShardingSphereDatabase [shardingsphere]
menghaoranss opened a new pull request, #39396:
URL: https://github.com/apache/shardingsphere/pull/39396
Changes proposed in this pull request:
- Add logical default schema lookup to ShardingSphereDatabase
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logical default schema lookup to ShardingSphereDatabase [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss commented on PR #39396:
URL: https://github.com/apache/shardingsphere/pull/39396#issuecomment-5238955067
```markdown
### Result
**Review Result: Mergeable**
No code-correctness blockers were found at the reviewed public head.
### Evidence
- `ShardingSphereDatabase.java:308-315` derives the logical default identifier through the protocol’s schema policy and returns the canonical stored schema name when one matches.
- `ShardingSphereDatabase.java:323-324` adds an `Optional` lookup that reuses the existing identifier-aware schema index.
- The additive API preserves existing signatures; the behavior change is limited to canonical default-schema resolution.
- `ShardingSphereDatabaseTest.java:321-360` covers fixed defaults, normalized defaults, canonical stored names, successful lookup, and missing schemas.
- Focused `ShardingSphereDatabaseTest`: 39 tests passed, exit 0.
- Scoped `infra/common` Checkstyle: zero violations, exit 0.
- The public API review used the repository’s manual contract and compatibility checklist because `$api-and-interface-design` was unavailable.
### Coverage
- Reviewed head: `5b152b5f9b6ec9907a09237ca633de336cdb39b8`
- Base and merge-base: `adb3c6fdcbbd28ef8d1eda778b40e8432cddceb2`
- Requirements: PR title and description; no linked issue or public review discussion.
- Both authoritative changed files were reviewed, and the local triple-dot file list matched GitHub.
- Behavior cluster: logical default-schema identity, canonical name resolution, and optional lookup.
- Reviewed PostgreSQL fixed-schema, Oracle normalized-schema, and MySQL case-insensitive matching behavior, plus shared callers in binder and single-table paths.
- Completed lenses: root cause and behavior; blast radius and contracts; tests, runtime, and operations.
- Convergence pass found zero new independent candidates.
- Unresolved evidence gaps: none.
- This is a code-scope result only; CI was not reviewed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logical default schema lookup to ShardingSphereDatabase [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss merged PR #39396:
URL: https://github.com/apache/shardingsphere/pull/39396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org