You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/03 16:30:32 UTC

[GitHub] [incubator-superset] betodealmeida edited a comment on issue #7032: Fetch charts with GET to benefit from browser cache and conditional requests

betodealmeida edited a comment on issue #7032: Fetch charts with GET to benefit from browser cache and conditional requests
URL: https://github.com/apache/incubator-superset/pull/7032#issuecomment-478697100
 
 
   @john-bodley @williaster 
   
   Sorry, I ran some numbers and forgot to post them here. I did a few tests with 4 examples dashboards:
   
   ![Improvement over current approach](https://user-images.githubusercontent.com/1534870/55351397-157d0d80-5473-11e9-8cd7-3004cf927c7d.png)
   
   The first request is without any caching (server restarted and browser cache clean). The second request is within the lifetime of the cache (1 minute, in this case). The third request is after the cache has expired, but the underlying data hasn't changed (so the ETag is used).
   
   For the "Misc Charts", eg, the first request is more than 20% faster, and the second and third requests are more than 50% faster.
   
   Here are the numbers:
   
   https://docs.google.com/spreadsheets/d/1bliQs6fnqni0lcNuxKRQ-A22RhOTiOI6OHZaR2tClh0/edit?usp=sharing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org