[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3212: [Alter]Clean SchemaChangeJobV2 when schema change CANCELLED or FINISHED

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #3212: [Alter]Clean SchemaChangeJobV2 when schema change CANCELLED or FINISHED
URL: https://github.com/apache/incubator-doris/pull/3212#discussion_r401340564
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java
 ##########
 @@ -953,4 +969,131 @@ public void readFields(DataInput in) throws IOException {
             }
         }
     }
+
+    /**
+     * write data need to persist when job finished
+     */
+    private void writeJobFinishedData(DataOutput out) throws IOException {
+        // only persist data will be used in getInfo
+        out.writeInt(indexIdMap.size());
 
 Review comment:
   Ignore me. I yesterday looked the code write `out.writeInt(indexIdMap.size());` twice. So I said write double.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org