[GitHub] [hudi] nsivabalan commented on a diff in pull request #8910: [HUDI-6342] Fixing flaky Continuous mode multi writer tests

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on code in PR #8910:
URL: https://github.com/apache/hudi/pull/8910#discussion_r1223690819


##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamerWithMultiWriter.java:
##########
@@ -404,12 +405,24 @@ private void runJobsInParallel(String tableBasePath, HoodieTableType tableType,
        * Need to perform getMessage().contains since the exception coming
        * from {@link org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer.DeltaSyncService} gets wrapped many times into RuntimeExceptions.
        */
-      if (expectConflict && e.getCause().getMessage().contains(ConcurrentModificationException.class.getName())) {
+      if (expectConflict && backfillFailed.get() && e.getCause().getMessage().contains(ConcurrentModificationException.class.getName())) {
         // expected ConcurrentModificationException since ingestion & backfill will have overlapping writes
-        if (backfillFailed.get()) {
+        if (!continuousFailed.get()) {

Review Comment:
   NTR: in most cases backfill job fails and hence the test succeeds. but if continuous job fails, the test times out. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org