You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/18 13:41:09 UTC

[GitHub] [spark] cloud-fan edited a comment on pull request #31653: [SPARK-33832][SQL] v2. move OptimzieSkewedJoin to query stage preparation

cloud-fan edited a comment on pull request #31653:
URL: https://github.com/apache/spark/pull/31653#issuecomment-801934545


   > and I need to know which ones were added by OptimizeSkewedJoin and which were added by something else.
   
   Sorry, I may miss something. This PR puts `OptimizeSkewedJoin` in the preparation rules. `CostEvaluator` compares the cost of the prepared physical plan and the re-optimized physical plan, so the extra shuffles added by `OptimizeSkewedJoin` is invisible to `CostEvaluator`.
   
   As I mentioned, `OptimizeSkewedJoin` should decide if extra shuffles are accepted or not, instead of waiting for the `CostEvaluator` to decide.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org