You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2020/08/05 19:23:23 UTC

[GitHub] [incubator-pagespeed-mod] oschaaf opened a new pull request #2028: Move pagespeed/kernel/base test specifics to test/

oschaaf opened a new pull request #2028:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2028


   Having test-specifics under `test/` is more convenient with bazel.
   This is a fist in a series of PRs to make that happen. 
   Major churn, but this should effectively be a no-op change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-mod] oschaaf merged pull request #2028: Move pagespeed/kernel/base test specifics to test/

Posted by GitBox <gi...@apache.org>.
oschaaf merged pull request #2028:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2028


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-mod] jmarantz commented on pull request #2028: Move pagespeed/kernel/base test specifics to test/

Posted by GitBox <gi...@apache.org>.
jmarantz commented on pull request #2028:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2028#issuecomment-669450950


   Why is it more convenient with bazel to have test files under test/... ?
   
   FWIW in Google we usually have the tests with the code being tested, and I think it was an artifact of pre-bazel Envoy (probably cmake) to put the tests in a separate directory.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-mod] jmarantz commented on pull request #2028: Move pagespeed/kernel/base test specifics to test/

Posted by GitBox <gi...@apache.org>.
jmarantz commented on pull request #2028:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2028#issuecomment-669483397


   RE shrinking the set of files in each directory: ok but we really should have a better directory organization :)
   
   RE compiling all the prod binaries easily: that's a pretty good argument :)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-mod] oschaaf commented on pull request #2028: Move pagespeed/kernel/base test specifics to test/

Posted by GitBox <gi...@apache.org>.
oschaaf commented on pull request #2028:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2028#issuecomment-669475984


   Well, I find it is useful anytime one wants to make an easy (non bazel-based) distinction  between test and production code. 
   One instance of that is running builds of just production code during development, e.g. `bazel build //pagespeed/...`, without remembering build target names. 
   Personally, I also find it helpful to have this separation, as this shrinks down the number of files that go into some of the existing directories, leaning up the listings to code relevant to production. Having said that, this is just personal preference -- if you feel this isn't worth it / shouldn't be done, I'd be happy to close this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org