You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/29 07:06:25 UTC
[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1741: Stub in advance to avoid WrongTypeOfReturnValue
TeslaCN opened a new pull request #1741:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1741
Fixes #1737
Changes proposed in this pull request:
- Stub in advance to avoid WrongTypeOfReturnValue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu merged pull request #1741: Stub in advance to avoid WrongTypeOfReturnValue
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #1741:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1741
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1741: Stub in advance to avoid WrongTypeOfReturnValue
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1741:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1741#issuecomment-735354199
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741?src=pr&el=h1) Report
> Merging [#1741](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741?src=pr&el=desc) (a4420d3) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/48ea0f0c005356a02313f2d5bed629c672d4dac8?el=desc) (48ea0f0) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1741 +/- ##
============================================
- Coverage 86.04% 85.97% -0.07%
Complexity 108 108
============================================
Files 255 255
Lines 5741 5741
Branches 885 885
============================================
- Hits 4940 4936 -4
- Misses 483 484 +1
- Partials 318 321 +3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <0.00%> (-1.59%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741?src=pr&el=footer). Last update [48ea0f0...a4420d3](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1741: Stub in advance to avoid WrongTypeOfReturnValue
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1741:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1741#issuecomment-735354199
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741?src=pr&el=h1) Report
> Merging [#1741](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741?src=pr&el=desc) (a4420d3) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/48ea0f0c005356a02313f2d5bed629c672d4dac8?el=desc) (48ea0f0) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1741 +/- ##
============================================
- Coverage 86.04% 86.03% -0.02%
Complexity 108 108
============================================
Files 255 255
Lines 5741 5741
Branches 885 885
============================================
- Hits 4940 4939 -1
Misses 483 483
- Partials 318 319 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <0.00%> (-1.59%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741?src=pr&el=footer). Last update [48ea0f0...a4420d3](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1741?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org