You are viewing a plain text version of this content. The canonical link for it is here.
Posted to wave-dev@incubator.apache.org by pablojan <gi...@git.apache.org> on 2016/12/06 11:29:23 UTC
[GitHub] incubator-wave pull request #18: Fixes taken from SwellRT
GitHub user pablojan opened a pull request:
https://github.com/apache/incubator-wave/pull/18
Fixes taken from SwellRT
This PR contains some bug fixes taken from SwellRT fork.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pablojan/incubator-wave fixes-pablojan
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-wave/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit 5d98dd1bf88d2cf58d3b2d127f82a5afb69063bd
Author: Pablo Ojanguren <pa...@gmail.com>
Date: 2016-12-06T10:35:59Z
Fix super dev launcher
commit 614d94b817df13a2a0ea75ddcc9094fde453d545
Author: Pablo Ojanguren <pa...@gmail.com>
Date: 2016-11-03T13:04:41Z
Fixes Chromium 54 doesn't support KeyboardEvent.keyIdentifier
commit 3dc20d6ac46e65be91002eb8db8dc1b3085405ce
Author: Pablo Ojanguren <pa...@gmail.com>
Date: 2016-11-04T17:08:19Z
Fixes #197 dead accent characters at end of line
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-wave issue #18: Fixes taken from SwellRT
Posted by wisebaldone <gi...@git.apache.org>.
Github user wisebaldone commented on the issue:
https://github.com/apache/incubator-wave/pull/18
LGTM. Tested with ./gradlew run
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-wave pull request #18: Fixes taken from SwellRT
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-wave/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-wave pull request #18: Fixes taken from SwellRT
Posted by Darin Willits <da...@gmail.com>.
Pablo,
Thanks for this. It seems to have fixed my debugging issues for now anyway.
Cheers,
Darin
> On Dec 6, 2016, at 6:29 AM, pablojan <gi...@git.apache.org> wrote:
>
> GitHub user pablojan opened a pull request:
>
> https://github.com/apache/incubator-wave/pull/18
>
> Fixes taken from SwellRT
>
> This PR contains some bug fixes taken from SwellRT fork.
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/pablojan/incubator-wave fixes-pablojan
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/incubator-wave/pull/18.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #18
>
> ----
> commit 5d98dd1bf88d2cf58d3b2d127f82a5afb69063bd
> Author: Pablo Ojanguren <pa...@gmail.com>
> Date: 2016-12-06T10:35:59Z
>
> Fix super dev launcher
>
> commit 614d94b817df13a2a0ea75ddcc9094fde453d545
> Author: Pablo Ojanguren <pa...@gmail.com>
> Date: 2016-11-03T13:04:41Z
>
> Fixes Chromium 54 doesn't support KeyboardEvent.keyIdentifier
>
> commit 3dc20d6ac46e65be91002eb8db8dc1b3085405ce
> Author: Pablo Ojanguren <pa...@gmail.com>
> Date: 2016-11-04T17:08:19Z
>
> Fixes #197 dead accent characters at end of line
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---