[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2394: Loan externalId unique validation

[GitBox <gi...@apache.org>]

josehernandezfintecheandomx commented on code in PR #2394:
URL: https://github.com/apache/fineract/pull/2394#discussion_r912385695


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepository.java:
##########
@@ -161,4 +163,7 @@ List<Loan> findByGroupOfficeIdsAndLoanStatus(@Param("officeIds") Collection<Long
     @Query(FIND_BY_ACCOUNT_NUMBER)
     Loan findLoanAccountByAccountNumber(@Param("accountNumber") String accountNumber);
 
+    @Query(DOES_EXISTS_LOAN_WITH_EXTERNAL_ID)
+    boolean validateIfExistLoanWithExternalId(@Param("externalId") String externalId);

Review Comment:
   Done!



##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepositoryWrapper.java:
##########
@@ -240,6 +240,10 @@ public Loan findNonClosedLoanByAccountNumber(@Param("accountNumber") String acco
         return this.repository.findNonClosedLoanByAccountNumber(accountNumber);
     }
 
+    public boolean validateIfExistLoanWithExternalId(@Param("externalId") String externalId) {

Review Comment:
   Done!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org