You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2016/04/27 01:06:43 UTC

Review Request 46715: HIVE-13596 HS2 should be able to get UDFs on demand from metastore

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46715/
-----------------------------------------------------------

Review request for hive and Jason Dere.


Repository: hive-git


Description
-------

see jira


Diffs
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java bae3999 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java d5f4a37 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 672df63 

Diff: https://reviews.apache.org/r/46715/diff/


Testing
-------


Thanks,

Sergey Shelukhin

Re: Review Request 46715: HIVE-13596 HS2 should be able to get UDFs on demand from metastore

Posted by Lefty Leverenz <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46715/#review131017
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2324 - 2326)
<https://reviews.apache.org/r/46715/#comment194943>

    Edits:
    
    "Whether enable" --> "Whether to enable"
    "HS2" --> "HiveServer2"
    
    Nice use of semicolon.  ;)


- Lefty Leverenz


On April 28, 2016, 12:20 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46715/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 12:20 a.m.)
> 
> 
> Review request for hive and Jason Dere.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 49d748c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java d5f4a37 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 672df63 
> 
> Diff: https://reviews.apache.org/r/46715/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 46715: HIVE-13596 HS2 should be able to get UDFs on demand from metastore

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46715/
-----------------------------------------------------------

(Updated April 28, 2016, 12:20 a.m.)


Review request for hive and Jason Dere.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 49d748c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java d5f4a37 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 672df63 

Diff: https://reviews.apache.org/r/46715/diff/


Testing
-------


Thanks,

Sergey Shelukhin

Re: Review Request 46715: HIVE-13596 HS2 should be able to get UDFs on demand from metastore

Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46715/#review130835
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java (line 450)
<https://reviews.apache.org/r/46715/#comment194734>

    agreed, this check could probably just use !=



ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java (line 703)
<https://reviews.apache.org/r/46715/#comment194735>

    Given that this is called by getQualifiedFunctionInfoUnderLock(), this should already be qualified, right?
    Also could use FunctionUtils.getQualifiedFunctionNameParts() which basically does this same logic here.



ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java (line 729)
<https://reviews.apache.org/r/46715/#comment194737>

    I think the function also needs to be added to the session registry.
    Does it work to use registerPermanentFunction() in place of the code from line 721-729? That seems to load the jars and add the UDF to the appropriate registries.


- Jason Dere


On April 26, 2016, 11:06 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46715/
> -----------------------------------------------------------
> 
> (Updated April 26, 2016, 11:06 p.m.)
> 
> 
> Review request for hive and Jason Dere.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java bae3999 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java d5f4a37 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 672df63 
> 
> Diff: https://reviews.apache.org/r/46715/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>