You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "bkietz (via GitHub)" <gi...@apache.org> on 2023/06/15 19:25:52 UTC
[GitHub] [arrow] bkietz opened a new issue, #36111: [C++] Refactor dict_internal.h to use Result
bkietz opened a new issue, #36111:
URL: https://github.com/apache/arrow/issues/36111
### Describe the enhancement requested
`DictionaryTraits<>::GetDictionaryArrayData` still uses the `Status(out ptr)` pattern instead of returning `Result<Out>`, which is less readable.
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] infdahai commented on issue #36111: [C++] Refactor dict_internal.h to use Result
Posted by "infdahai (via GitHub)" <gi...@apache.org>.
infdahai commented on issue #36111:
URL: https://github.com/apache/arrow/issues/36111#issuecomment-1598888236
I'd like to task this task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz closed issue #36111: [C++] Refactor dict_internal.h to use Result
Posted by "bkietz (via GitHub)" <gi...@apache.org>.
bkietz closed issue #36111: [C++] Refactor dict_internal.h to use Result
URL: https://github.com/apache/arrow/issues/36111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] chrisjordansquire commented on issue #36111: [C++] Refactor dict_internal.h to use Result
Posted by "chrisjordansquire (via GitHub)" <gi...@apache.org>.
chrisjordansquire commented on issue #36111:
URL: https://github.com/apache/arrow/issues/36111#issuecomment-1722274884
@bkietz - I made a PR for this issue at https://github.com/apache/arrow/pull/37754 . I'm unsure if I correctly interpreted the task. Feedback greatly appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on issue #36111: [C++] Refactor dict_internal.h to use Result
Posted by "bkietz (via GitHub)" <gi...@apache.org>.
bkietz commented on issue #36111:
URL: https://github.com/apache/arrow/issues/36111#issuecomment-1599295898
If you write a PR, @mention me and I'll review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] infdahai commented on issue #36111: [C++] Refactor dict_internal.h to use Result
Posted by "infdahai (via GitHub)" <gi...@apache.org>.
infdahai commented on issue #36111:
URL: https://github.com/apache/arrow/issues/36111#issuecomment-1599835627
I get it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org