You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2021/07/23 12:46:08 UTC

[GitHub] [incubator-brpc] JockerWong opened a new issue #1496: The relationship between qps and _explore_ratio

JockerWong opened a new issue #1496:
URL: https://github.com/apache/incubator-brpc/issues/1496


   https://github.com/apache/incubator-brpc/blob/53f6436a63f4b4c23d22b9e07e5d6d9af8af7fe7/src/brpc/policy/auto_concurrency_limiter.cpp#L254
   
   I think it should be "qps >= _ema_max_qps / (1.0 + min_explore_ratio", that is, when the qps decrease is not obvious, you can continue to increase the explore speed. And when the qps decreases significantly, you need to reduce the explore speed.
   I don't know whether my understanding is correct.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] TousakaRin commented on issue #1496: The relationship between qps and _explore_ratio

Posted by GitBox <gi...@apache.org>.
TousakaRin commented on issue #1496:
URL: https://github.com/apache/incubator-brpc/issues/1496#issuecomment-912347479


   When your max_concurrency is set too large, we think that latency will increase in most cases and qps will remain near max_qps, so when qps is smaller than the known max_qps(_ema_max_qps), we will try to increase max_concurrency.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] cdjingit commented on issue #1496: The relationship between qps and _explore_ratio

Posted by GitBox <gi...@apache.org>.
cdjingit commented on issue #1496:
URL: https://github.com/apache/incubator-brpc/issues/1496#issuecomment-911421464


   @TousakaRin Would you please help to check this issue about auto concurrency limiter?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org