[GitHub] HyukjinKwon commented on a change in pull request #23444: [SPARK-26529]Add logs for IOException when preparing local resource

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #23444: [SPARK-26529]Add logs for IOException when preparing local resource
URL: https://github.com/apache/spark/pull/23444#discussion_r245214949
 
 

 ##########
 File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
 ##########
 @@ -780,10 +780,19 @@ private[spark] class Client(
       props.store(writer, "Spark configuration.")
       writer.flush()
       confStream.closeEntry()
+      confArchive
+    } catch {
+      case e: IOException =>
+        logError(s"IOException occurred while writing to confArchive $confArchive", e)
+        throw e
 
 Review comment:
   Why do we need to log error when the exception is thrown?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org