You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2021/11/17 16:59:40 UTC

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #344: Improved: Invoice Payments for user with 'VIEW' permission (OFBIZ-12384)

JacquesLeRoux commented on pull request #344:
URL: https://github.com/apache/ofbiz-framework/pull/344#issuecomment-971773442


   Quoting Michael
   ```
   You missed my point. If you want to fix something which is broken, please do it solely in a PR and avoid to introduce additional changes. It's harder to test/review and also has more risks to introduce additional bugs if you mix it up with other changes.
   
   Changes like name changes also have to be dicussed and reviewed diffrently from bug fixes. They should not slip in with a bug fix
   ```
   Also it's often quite harder to revert...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org