You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/06/04 21:50:12 UTC
Review Request 35085: Removing A Host Does Not Recalculate Aggregate
Alerts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35085/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Tom Beerbower.
Bugs: AMBARI-11699
https://issues.apache.org/jira/browse/AMBARI-11699
Repository: ambari
Description
-------
- Deploy cluster with HBASE, 3 nodes
- Stop and delete Region Server from one of the 3 hosts.
- Alert shows wrong data even after 10 minutes.
The root cause of this is that the aggregate alerts only recalculate on a state change. We need to explicitly force the recalculation.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/events/AggregateAlertRecalculateEvent.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java 99542ef
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceComponentHostListener.java 92008e3
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java ef0430e
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java c63c0d4
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 6bf808d
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java e37f0cb
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java 67c08ba
Diff: https://reviews.apache.org/r/35085/diff/
Testing
-------
mvn clean test
Also, removed a host which had alerts which were aggregated and saw the aggregate alert recalculate.
Thanks,
Jonathan Hurley
Re: Review Request 35085: Removing A Host Does Not Recalculate
Aggregate Alerts
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35085/#review86719
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On June 4, 2015, 7:50 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35085/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 7:50 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-11699
> https://issues.apache.org/jira/browse/AMBARI-11699
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Deploy cluster with HBASE, 3 nodes
> - Stop and delete Region Server from one of the 3 hosts.
> - Alert shows wrong data even after 10 minutes.
>
> The root cause of this is that the aggregate alerts only recalculate on a state change. We need to explicitly force the recalculation.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/AggregateAlertRecalculateEvent.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java 99542ef
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceComponentHostListener.java 92008e3
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java ef0430e
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java c63c0d4
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 6bf808d
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java e37f0cb
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java 67c08ba
>
> Diff: https://reviews.apache.org/r/35085/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Also, removed a host which had alerts which were aggregated and saw the aggregate alert recalculate.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 35085: Removing A Host Does Not Recalculate
Aggregate Alerts
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35085/#review86743
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On June 4, 2015, 3:50 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35085/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 3:50 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-11699
> https://issues.apache.org/jira/browse/AMBARI-11699
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Deploy cluster with HBASE, 3 nodes
> - Stop and delete Region Server from one of the 3 hosts.
> - Alert shows wrong data even after 10 minutes.
>
> The root cause of this is that the aggregate alerts only recalculate on a state change. We need to explicitly force the recalculation.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/AggregateAlertRecalculateEvent.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java 99542ef
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceComponentHostListener.java 92008e3
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java ef0430e
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java c63c0d4
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 6bf808d
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java e37f0cb
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java 67c08ba
>
> Diff: https://reviews.apache.org/r/35085/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Also, removed a host which had alerts which were aggregated and saw the aggregate alert recalculate.
>
>
> Thanks,
>
> Jonathan Hurley
>
>