You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Jingguo Yao (JIRA)" <ji...@apache.org> on 2010/11/23 15:04:16 UTC
[jira] Created: (HADOOP-7048) Wrong description of Block-Compressed
SequenceFile Format in SequenceFile's javadoc
Wrong description of Block-Compressed SequenceFile Format in SequenceFile's javadoc
-----------------------------------------------------------------------------------
Key: HADOOP-7048
URL: https://issues.apache.org/jira/browse/HADOOP-7048
Project: Hadoop Common
Issue Type: Improvement
Components: io
Affects Versions: 0.21.0
Reporter: Jingguo Yao
Priority: Minor
Here is the following description for Block-Compressed SequenceFile Format in SequenceFile's javadoc:
* <li>
* Record <i>Block</i>
* <ul>
* <li>Compressed key-lengths block-size</li>
* <li>Compressed key-lengths block</li>
* <li>Compressed keys block-size</li>
* <li>Compressed keys block</li>
* <li>Compressed value-lengths block-size</li>
* <li>Compressed value-lengths block</li>
* <li>Compressed values block-size</li>
* <li>Compressed values block</li>
* </ul>
* </li>
* <li>
* A sync-marker every few <code>100</code> bytes or so.
* </li>
This description misses "Uncompressed record number in the block". And "A sync-marker every few <code>100</code> bytes or so" is not the case for Block-Compressed SequenceFile Format. Correct description should be:
* <li>
* Record <i>Block</i>
* <ul>
* <li>Uncompressed record number in the block</li>
* <li>Compressed key-lengths block-size</li>
* <li>Compressed key-lengths block</li>
* <li>Compressed keys block-size</li>
* <li>Compressed keys block</li>
* <li>Compressed value-lengths block-size</li>
* <li>Compressed value-lengths block</li>
* <li>Compressed values block-size</li>
* <li>Compressed values block</li>
* </ul>
* </li>
* <li>
* A sync-marker every block.
* </li>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7048) Wrong description of Block-Compressed
SequenceFile Format in SequenceFile's javadoc
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-7048:
------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Assignee: Jingguo Yao
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've just committed this. Thanks Jingguo Yao!
> Wrong description of Block-Compressed SequenceFile Format in SequenceFile's javadoc
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-7048
> URL: https://issues.apache.org/jira/browse/HADOOP-7048
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.21.0
> Reporter: Jingguo Yao
> Assignee: Jingguo Yao
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7048.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> Here is the following description for Block-Compressed SequenceFile Format in SequenceFile's javadoc:
> * <li>
> * Record <i>Block</i>
> * <ul>
> * <li>Compressed key-lengths block-size</li>
> * <li>Compressed key-lengths block</li>
> * <li>Compressed keys block-size</li>
> * <li>Compressed keys block</li>
> * <li>Compressed value-lengths block-size</li>
> * <li>Compressed value-lengths block</li>
> * <li>Compressed values block-size</li>
> * <li>Compressed values block</li>
> * </ul>
> * </li>
> * <li>
> * A sync-marker every few <code>100</code> bytes or so.
> * </li>
> This description misses "Uncompressed record number in the block". And "A sync-marker every few <code>100</code> bytes or so" is not the case for Block-Compressed SequenceFile Format. Correct description should be:
> * <li>
> * Record <i>Block</i>
> * <ul>
> * <li>Uncompressed record number in the block</li>
> * <li>Compressed key-lengths block-size</li>
> * <li>Compressed key-lengths block</li>
> * <li>Compressed keys block-size</li>
> * <li>Compressed keys block</li>
> * <li>Compressed value-lengths block-size</li>
> * <li>Compressed value-lengths block</li>
> * <li>Compressed values block-size</li>
> * <li>Compressed values block</li>
> * </ul>
> * </li>
> * <li>
> * A sync-marker every block.
> * </li>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7048) Wrong description of Block-Compressed
SequenceFile Format in SequenceFile's javadoc
Posted by "Jingguo Yao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jingguo Yao updated HADOOP-7048:
--------------------------------
Status: Patch Available (was: Open)
> Wrong description of Block-Compressed SequenceFile Format in SequenceFile's javadoc
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-7048
> URL: https://issues.apache.org/jira/browse/HADOOP-7048
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.21.0
> Reporter: Jingguo Yao
> Priority: Minor
> Attachments: HADOOP-7048.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Here is the following description for Block-Compressed SequenceFile Format in SequenceFile's javadoc:
> * <li>
> * Record <i>Block</i>
> * <ul>
> * <li>Compressed key-lengths block-size</li>
> * <li>Compressed key-lengths block</li>
> * <li>Compressed keys block-size</li>
> * <li>Compressed keys block</li>
> * <li>Compressed value-lengths block-size</li>
> * <li>Compressed value-lengths block</li>
> * <li>Compressed values block-size</li>
> * <li>Compressed values block</li>
> * </ul>
> * </li>
> * <li>
> * A sync-marker every few <code>100</code> bytes or so.
> * </li>
> This description misses "Uncompressed record number in the block". And "A sync-marker every few <code>100</code> bytes or so" is not the case for Block-Compressed SequenceFile Format. Correct description should be:
> * <li>
> * Record <i>Block</i>
> * <ul>
> * <li>Uncompressed record number in the block</li>
> * <li>Compressed key-lengths block-size</li>
> * <li>Compressed key-lengths block</li>
> * <li>Compressed keys block-size</li>
> * <li>Compressed keys block</li>
> * <li>Compressed value-lengths block-size</li>
> * <li>Compressed value-lengths block</li>
> * <li>Compressed values block-size</li>
> * <li>Compressed values block</li>
> * </ul>
> * </li>
> * <li>
> * A sync-marker every block.
> * </li>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7048) Wrong description of
Block-Compressed SequenceFile Format in SequenceFile's javadoc
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993360#comment-12993360 ]
Hudson commented on HADOOP-7048:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #498 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/498/])
HADOOP-7048. Wrong description of Block-Compressed SequenceFile Format in SequenceFile's javadoc. Contributed by Jingguo Yao.
> Wrong description of Block-Compressed SequenceFile Format in SequenceFile's javadoc
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-7048
> URL: https://issues.apache.org/jira/browse/HADOOP-7048
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.21.0
> Reporter: Jingguo Yao
> Assignee: Jingguo Yao
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7048.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> Here is the following description for Block-Compressed SequenceFile Format in SequenceFile's javadoc:
> * <li>
> * Record <i>Block</i>
> * <ul>
> * <li>Compressed key-lengths block-size</li>
> * <li>Compressed key-lengths block</li>
> * <li>Compressed keys block-size</li>
> * <li>Compressed keys block</li>
> * <li>Compressed value-lengths block-size</li>
> * <li>Compressed value-lengths block</li>
> * <li>Compressed values block-size</li>
> * <li>Compressed values block</li>
> * </ul>
> * </li>
> * <li>
> * A sync-marker every few <code>100</code> bytes or so.
> * </li>
> This description misses "Uncompressed record number in the block". And "A sync-marker every few <code>100</code> bytes or so" is not the case for Block-Compressed SequenceFile Format. Correct description should be:
> * <li>
> * Record <i>Block</i>
> * <ul>
> * <li>Uncompressed record number in the block</li>
> * <li>Compressed key-lengths block-size</li>
> * <li>Compressed key-lengths block</li>
> * <li>Compressed keys block-size</li>
> * <li>Compressed keys block</li>
> * <li>Compressed value-lengths block-size</li>
> * <li>Compressed value-lengths block</li>
> * <li>Compressed values block-size</li>
> * <li>Compressed values block</li>
> * </ul>
> * </li>
> * <li>
> * A sync-marker every block.
> * </li>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7048) Wrong description of Block-Compressed
SequenceFile Format in SequenceFile's javadoc
Posted by "Jingguo Yao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jingguo Yao updated HADOOP-7048:
--------------------------------
Attachment: HADOOP-7048.patch
Patch available.
> Wrong description of Block-Compressed SequenceFile Format in SequenceFile's javadoc
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-7048
> URL: https://issues.apache.org/jira/browse/HADOOP-7048
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.21.0
> Reporter: Jingguo Yao
> Priority: Minor
> Attachments: HADOOP-7048.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Here is the following description for Block-Compressed SequenceFile Format in SequenceFile's javadoc:
> * <li>
> * Record <i>Block</i>
> * <ul>
> * <li>Compressed key-lengths block-size</li>
> * <li>Compressed key-lengths block</li>
> * <li>Compressed keys block-size</li>
> * <li>Compressed keys block</li>
> * <li>Compressed value-lengths block-size</li>
> * <li>Compressed value-lengths block</li>
> * <li>Compressed values block-size</li>
> * <li>Compressed values block</li>
> * </ul>
> * </li>
> * <li>
> * A sync-marker every few <code>100</code> bytes or so.
> * </li>
> This description misses "Uncompressed record number in the block". And "A sync-marker every few <code>100</code> bytes or so" is not the case for Block-Compressed SequenceFile Format. Correct description should be:
> * <li>
> * Record <i>Block</i>
> * <ul>
> * <li>Uncompressed record number in the block</li>
> * <li>Compressed key-lengths block-size</li>
> * <li>Compressed key-lengths block</li>
> * <li>Compressed keys block-size</li>
> * <li>Compressed keys block</li>
> * <li>Compressed value-lengths block-size</li>
> * <li>Compressed value-lengths block</li>
> * <li>Compressed values block-size</li>
> * <li>Compressed values block</li>
> * </ul>
> * </li>
> * <li>
> * A sync-marker every block.
> * </li>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7048) Wrong description of
Block-Compressed SequenceFile Format in SequenceFile's javadoc
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993448#comment-12993448 ]
Hudson commented on HADOOP-7048:
--------------------------------
Integrated in Hadoop-Common-trunk #603 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/603/])
HADOOP-7048. Wrong description of Block-Compressed SequenceFile Format in SequenceFile's javadoc. Contributed by Jingguo Yao.
> Wrong description of Block-Compressed SequenceFile Format in SequenceFile's javadoc
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-7048
> URL: https://issues.apache.org/jira/browse/HADOOP-7048
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.21.0
> Reporter: Jingguo Yao
> Assignee: Jingguo Yao
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7048.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> Here is the following description for Block-Compressed SequenceFile Format in SequenceFile's javadoc:
> * <li>
> * Record <i>Block</i>
> * <ul>
> * <li>Compressed key-lengths block-size</li>
> * <li>Compressed key-lengths block</li>
> * <li>Compressed keys block-size</li>
> * <li>Compressed keys block</li>
> * <li>Compressed value-lengths block-size</li>
> * <li>Compressed value-lengths block</li>
> * <li>Compressed values block-size</li>
> * <li>Compressed values block</li>
> * </ul>
> * </li>
> * <li>
> * A sync-marker every few <code>100</code> bytes or so.
> * </li>
> This description misses "Uncompressed record number in the block". And "A sync-marker every few <code>100</code> bytes or so" is not the case for Block-Compressed SequenceFile Format. Correct description should be:
> * <li>
> * Record <i>Block</i>
> * <ul>
> * <li>Uncompressed record number in the block</li>
> * <li>Compressed key-lengths block-size</li>
> * <li>Compressed key-lengths block</li>
> * <li>Compressed keys block-size</li>
> * <li>Compressed keys block</li>
> * <li>Compressed value-lengths block-size</li>
> * <li>Compressed value-lengths block</li>
> * <li>Compressed values block-size</li>
> * <li>Compressed values block</li>
> * </ul>
> * </li>
> * <li>
> * A sync-marker every block.
> * </li>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7048) Wrong description of
Block-Compressed SequenceFile Format in SequenceFile's javadoc
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934846#action_12934846 ]
Hadoop QA commented on HADOOP-7048:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12460267/HADOOP-7048.patch
against trunk revision 1038003.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/118//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/118//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/118//console
This message is automatically generated.
> Wrong description of Block-Compressed SequenceFile Format in SequenceFile's javadoc
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-7048
> URL: https://issues.apache.org/jira/browse/HADOOP-7048
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.21.0
> Reporter: Jingguo Yao
> Priority: Minor
> Attachments: HADOOP-7048.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Here is the following description for Block-Compressed SequenceFile Format in SequenceFile's javadoc:
> * <li>
> * Record <i>Block</i>
> * <ul>
> * <li>Compressed key-lengths block-size</li>
> * <li>Compressed key-lengths block</li>
> * <li>Compressed keys block-size</li>
> * <li>Compressed keys block</li>
> * <li>Compressed value-lengths block-size</li>
> * <li>Compressed value-lengths block</li>
> * <li>Compressed values block-size</li>
> * <li>Compressed values block</li>
> * </ul>
> * </li>
> * <li>
> * A sync-marker every few <code>100</code> bytes or so.
> * </li>
> This description misses "Uncompressed record number in the block". And "A sync-marker every few <code>100</code> bytes or so" is not the case for Block-Compressed SequenceFile Format. Correct description should be:
> * <li>
> * Record <i>Block</i>
> * <ul>
> * <li>Uncompressed record number in the block</li>
> * <li>Compressed key-lengths block-size</li>
> * <li>Compressed key-lengths block</li>
> * <li>Compressed keys block-size</li>
> * <li>Compressed keys block</li>
> * <li>Compressed value-lengths block-size</li>
> * <li>Compressed value-lengths block</li>
> * <li>Compressed values block-size</li>
> * <li>Compressed values block</li>
> * </ul>
> * </li>
> * <li>
> * A sync-marker every block.
> * </li>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.