You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "boneanxs (via GitHub)" <gi...@apache.org> on 2023/02/01 09:45:06 UTC

[GitHub] [incubator-celeborn] boneanxs opened a new pull request, #1196: [CELEBORN-264] InFlight requests should not be expired if it's not pushed yet

boneanxs opened a new pull request, #1196:
URL: https://github.com/apache/incubator-celeborn/pull/1196

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   Give inFlightRequest's `pushTime` an initial negative value, and `InFlightRequestsTracker` will only expire requests if it's `pushTime` is not negative
   
   
   ### Why are the changes needed?
   
   `ShuffleClientImpl` first add batch to the `pushState`, and `pushTime` is assigned value in `pushState.pushStarted`, which is after the method `pushState.addBatch`, so it's possible to wrongly throw the exception `PushDataTimeout`.
   
   For example,
   1. pushState add batch 1, whose `pushTime` is initialized by 0 (Long)
   2. Another push request calls `limitMaxInFlight` to check the limit, and batch 1 will be expired (since currentTime - 0 usually is larger than pushTimeoutMs)
   ![SeaTalk_IMG_1675235878](https://user-images.githubusercontent.com/10115332/216007808-e07edb73-1854-4907-9d92-00b96c67bb9d.png)
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   MT. After add the patch, the issue doesn't occur anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1196: [CELEBORN-264] InFlight requests should not be expired if it's not pushed yet

Posted by codecov.
codecov[bot] commented on PR #1196:
URL: https://github.com/apache/incubator-celeborn/pull/1196#issuecomment-1411770504

   # [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1196?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1196](https://codecov.io/gh/apache/incubator-celeborn/pull/1196?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bcf2e5d) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/2577f09938f09ea0a07049a98e5ee6484fdd9a3a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2577f09) will **decrease** coverage by `0.07%`.
   > The diff coverage is `87.50%`.
   
   > :exclamation: Current head bcf2e5d differs from pull request most recent head 5e9929d. Consider uploading reports for the commit 5e9929d to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #1196      +/-   ##
   ============================================
   - Coverage     26.93%   26.85%   -0.07%     
   + Complexity      779      773       -6     
   ============================================
     Files           205      205              
     Lines         17432    17427       -5     
     Branches       1899     1899              
   ============================================
   - Hits           4693     4679      -14     
   - Misses        12417    12421       +4     
   - Partials        322      327       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../celeborn/client/write/InFlightRequestTracker.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jbGllbnQvd3JpdGUvSW5GbGlnaHRSZXF1ZXN0VHJhY2tlci5qYXZh) | `26.86% <50.00%> (+0.69%)` | :arrow_up: |
   | [...ommon/network/client/TransportResponseHandler.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9jbGllbnQvVHJhbnNwb3J0UmVzcG9uc2VIYW5kbGVyLmphdmE=) | `73.05% <100.00%> (-1.33%)` | :arrow_down: |
   | [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `69.27% <0.00%> (-2.45%)` | :arrow_down: |
   | [...ice/deploy/master/clustermeta/ha/HARaftServer.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvY2x1c3Rlcm1ldGEvaGEvSEFSYWZ0U2VydmVyLmphdmE=) | `76.58% <0.00%> (-1.35%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] waitinfuture merged pull request #1196: [CELEBORN-264] InFlight requests should not be expired if it's not pushed yet

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1196:
URL: https://github.com/apache/incubator-celeborn/pull/1196


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org