You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by hn...@apache.org on 2022/11/03 09:13:14 UTC

[myfaces-tobago] 01/02: feat(selectMany): rename tobago-filter-wrapper to tobago-select-field

This is an automated email from the ASF dual-hosted git repository.

hnoeth pushed a commit to branch t5_selectMany
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git

commit e3e3301068b35a5e2e92e641999f3d44df74221e
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Thu Nov 3 10:12:49 2022 +0100

    feat(selectMany): rename tobago-filter-wrapper to tobago-select-field
    
    Issue: TOBAGO-2159
---
 .../tobago/internal/renderkit/renderer/SelectManyRenderer.java        | 4 ++--
 .../java/org/apache/myfaces/tobago/renderkit/css/TobagoClass.java     | 2 +-
 tobago-theme/src/main/scss/_tobago.scss                               | 4 ++--
 tobago-theme/tobago-theme-standard/src/main/ts/tobago-select-many.ts  | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyRenderer.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyRenderer.java
index ccd7cc34ce..512a1fdf6b 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyRenderer.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyRenderer.java
@@ -124,7 +124,7 @@ public class SelectManyRenderer<T extends AbstractUISelectMany> extends SelectMa
 
   @Override
   protected void writeAdditionalAttributes(FacesContext facesContext, TobagoResponseWriter writer, T input)
-      throws IOException {
+    throws IOException {
     super.writeAdditionalAttributes(facesContext, writer, input);
     writer.writeAttribute(CustomAttributes.FILTER, input.getFilter(), true);
   }
@@ -173,7 +173,7 @@ public class SelectManyRenderer<T extends AbstractUISelectMany> extends SelectMa
     HtmlRendererUtils.writeDataAttributes(facesContext, writer, component);
     writer.writeClassAttribute(
       inline ? BootstrapClass.FORM_CONTROL : BootstrapClass.FORM_SELECT,
-      TobagoClass.FILTER__WRAPPER,
+      TobagoClass.SELECT__FIELD,
       inline ? BootstrapClass.LIST_GROUP_ITEM : BootstrapClass.DROPDOWN_TOGGLE,
       BootstrapClass.borderColor(ComponentUtils.getMaximumSeverity(component)),
       component.getCustomClass());
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/renderkit/css/TobagoClass.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/renderkit/css/TobagoClass.java
index 1d9d4b4fb3..02ca850768 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/renderkit/css/TobagoClass.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/renderkit/css/TobagoClass.java
@@ -57,7 +57,6 @@ public enum TobagoClass implements CssItem {
   FOCUS("tobago-focus"),
   FOLDER("tobago-folder"),
   FILTER("tobago-filter"),
-  FILTER__WRAPPER("tobago-filter-wrapper"),
   HEADER("tobago-header"),
 //  IMAGE("tobago-image"),
   // tbd: can be removed?
@@ -84,6 +83,7 @@ public enum TobagoClass implements CssItem {
   REQUIRED("tobago-required"),
   RESIZE("tobago-resize"),
   SECTION__CONTENT("tobago-section-content"),
+  SELECT__FIELD("tobago-select-field"),
   SELECT_MANY_LISTBOX__OPTION("tobago-selectManyListbox-option"),
 //  SELECT_MANY_SHUTTLE("tobago-selectManyShuttle"),
 //  SELECT_MANY_SHUTTLE__ADD("tobago-selectManyShuttle-add"),
diff --git a/tobago-theme/src/main/scss/_tobago.scss b/tobago-theme/src/main/scss/_tobago.scss
index 8d66f11cd9..d4d20347f8 100644
--- a/tobago-theme/src/main/scss/_tobago.scss
+++ b/tobago-theme/src/main/scss/_tobago.scss
@@ -1199,7 +1199,7 @@ tobago-select-many {
   }
 
   &.tobago-focus {
-    &.dropdown .tobago-filter-wrapper {
+    &.dropdown .tobago-select-field {
       @include formControlFocus();
     }
 
@@ -1208,7 +1208,7 @@ tobago-select-many {
     }
   }
 
-  .tobago-filter-wrapper {
+  .tobago-select-field {
     display: flex;
     flex-wrap: wrap;
     align-items: center;
diff --git a/tobago-theme/tobago-theme-standard/src/main/ts/tobago-select-many.ts b/tobago-theme/tobago-theme-standard/src/main/ts/tobago-select-many.ts
index cd2fef5fd8..ead14f6c17 100644
--- a/tobago-theme/tobago-theme-standard/src/main/ts/tobago-select-many.ts
+++ b/tobago-theme/tobago-theme-standard/src/main/ts/tobago-select-many.ts
@@ -40,7 +40,7 @@ class SelectMany extends HTMLElement {
   }
 
   get selectField(): HTMLDivElement {
-    return this.querySelector(".tobago-filter-wrapper");
+    return this.querySelector(".tobago-select-field");
   }
 
   get badgeCloseButtons(): NodeListOf<HTMLButtonElement> {