You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/03 12:46:52 UTC

[GitHub] [airflow] mik-laj opened a new pull request #9119: Move TestDagFileProcessorQueriesCount to quarantine

mik-laj opened a new pull request #9119:
URL: https://github.com/apache/airflow/pull/9119


   I was able to repeat this problem locally, but I still need some time to investigate the cause.It may be related to this line:
   https://github.com/apache/airflow/blob/10796cb7ce52c8ac2f68024e531fdda779547bdf/airflow/jobs/scheduler_job.py#L692
   
   When I do the following changes in this file
   ```diff
           # update the state of the previously active dag runs
           active_dag_runs = 0
           task_instances_list = []
   -       for run in dag_runs:
   +       for run in sorted(dag_runs, key=lambda d: d.execution_date):
               self.log.info("Examining DAG run %s", run)
               # don't consider runs that are executed in the future unless
               # specified by config and schedule_interval is None
   ```
   I am not sure if this is a good solution.
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Target Github ISSUE in description if exists
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #9119: Move TestDagFileProcessorQueriesCount to quarantine

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9119:
URL: https://github.com/apache/airflow/pull/9119#issuecomment-638294161


   Seems odd at first glance that sorting a list in python would change the number of queries... :thinking: I wonder what's going on here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj merged pull request #9119: Move TestDagFileProcessorQueriesCount to quarantine

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #9119:
URL: https://github.com/apache/airflow/pull/9119


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on pull request #9119: Move TestDagFileProcessorQueriesCount to quarantine

Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #9119:
URL: https://github.com/apache/airflow/pull/9119#issuecomment-638197117


   @mik-laj this "time-related" problem is something I observed too 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org