You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/19 01:26:51 UTC

[GitHub] [arrow] jianxind commented on pull request #7213: ARROW-8841: [C++] Add benchmark and unittest for encoding::PLAIN spaced

jianxind commented on pull request #7213:
URL: https://github.com/apache/arrow/pull/7213#issuecomment-630520835


   > Suggestions:
   > 
   > * Either `Int32` and `Int64`, or `Float` and `Double`, are sufficient; I don't think both at the same time are useful (they should use the same respective code paths)
   > * It may be nice to add tests with null probability 90% and 99%
   
   Thanks. Yes the int32/int64 are the same path to float/double, even for SIMD, I removed it. 90% and 99% added also.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org