You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "C. Michael Pilato" <cm...@collab.net> on 2011/02/22 18:18:36 UTC

Re: svn commit: r1073325 - /subversion/trunk/contrib/client-side/svn_apply_autoprops.py

On 02/22/2011 08:51 AM, stsp@apache.org wrote:
> Author: stsp
> Date: Tue Feb 22 13:51:16 2011
> New Revision: 1073325

[...]

> In some situations users might want to use a different configuration file
> to configure a specific set of autoprops, so add a new --config option.

<bikeshed>
Should we use "--config-dir" for consistency with other Subversion tools?
</bikeshed>

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand


Re: svn commit: r1073325 - /subversion/trunk/contrib/client-side/svn_apply_autoprops.py

Posted by Stefan Sperling <st...@apache.org>.
On Tue, Feb 22, 2011 at 12:18:36PM -0500, C. Michael Pilato wrote:
> On 02/22/2011 08:51 AM, stsp@apache.org wrote:
> > Author: stsp
> > Date: Tue Feb 22 13:51:16 2011
> > New Revision: 1073325
> 
> [...]
> 
> > In some situations users might want to use a different configuration file
> > to configure a specific set of autoprops, so add a new --config option.
> 
> <bikeshed>
> Should we use "--config-dir" for consistency with other Subversion tools?
> </bikeshed>
> 

The way it's written now it expects a config filename, not a config directory.
I suppose it could be make to look into a specified directory for a 
file called 'config' instead. Though that would make things a bit harder
for folks who want to prepare a file like this:

cat > /tmp/myautoprops <<EOF
[auto-props]
*.c = svn:eol-style=native
*.h = svn:keywords=Author Date Id Rev URL;svn:eol-style=native
*.txt = svn:eol-style=native;svn:keywords=Author Date Id Rev URL;
EOF

and then want to use it.
Even though that's not a valid subversion config file (enable-auto-props
is missing), this works with the script.

Re: svn commit: r1073325 - /subversion/trunk/contrib/client-side/svn_apply_autoprops.py

Posted by Stefan Sperling <st...@apache.org>.
On Tue, Feb 22, 2011 at 12:18:36PM -0500, C. Michael Pilato wrote:
> On 02/22/2011 08:51 AM, stsp@apache.org wrote:
> > Author: stsp
> > Date: Tue Feb 22 13:51:16 2011
> > New Revision: 1073325
> 
> [...]
> 
> > In some situations users might want to use a different configuration file
> > to configure a specific set of autoprops, so add a new --config option.
> 
> <bikeshed>
> Should we use "--config-dir" for consistency with other Subversion tools?
> </bikeshed>
> 

The way it's written now it expects a config filename, not a config directory.
I suppose it could be make to look into a specified directory for a 
file called 'config' instead. Though that would make things a bit harder
for folks who want to prepare a file like this:

cat > /tmp/myautoprops <<EOF
[auto-props]
*.c = svn:eol-style=native
*.h = svn:keywords=Author Date Id Rev URL;svn:eol-style=native
*.txt = svn:eol-style=native;svn:keywords=Author Date Id Rev URL;
EOF

and then want to use it.
Even though that's not a valid subversion config file (enable-auto-props
is missing), this works with the script.